Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gcp-e2e-kubernetes job #304

Merged
merged 4 commits into from Aug 20, 2020
Merged

Enable gcp-e2e-kubernetes job #304

merged 4 commits into from Aug 20, 2020

Conversation

marun
Copy link

@marun marun commented Aug 5, 2020 •
edited

This PR copies origin's test annotation capability to support building a k8s-e2e.test binary whose execution can be limited to openshift-compatible tests. This enables an e2e job that validates the current state of the repo with its own tests in advance of those tests being vendored into origin for incorporation into openshift-tests.

Once this PR has merged, origin can be bumped to reuse the test annotation code defined in this repo to ensure it is maintained in only one place:

openshift/origin#25382

@marun marun requested review from mfojtik, sttts and deads2k August 5, 2020 02:55
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. vendor-update Touching vendor dir or related files labels Aug 5, 2020
@marun
Copy link
Author

marun commented Aug 5, 2020

/test gcp-e2e-kubernetes

@marun marun changed the title WIP Enable kube-e2e-gcp job WIP Enable k8s-e2e-gcp job Aug 5, 2020
@marun marun changed the title WIP Enable k8s-e2e-gcp job WIP Enable gcp-e2e-kubernetes job Aug 5, 2020
@marun
Copy link
Author

marun commented Aug 5, 2020

/test gcp-e2e-kubernetes

@marun
Copy link
Author

marun commented Aug 5, 2020

/test e2e-aws-fips

@marun marun force-pushed the kube-e2e branch 3 times, most recently from 30db924 to 95460a6 Compare August 6, 2020 05:01
@marun marun mentioned this pull request Aug 6, 2020
Merged
@marun
Copy link
Author

marun commented Aug 6, 2020

/cc @smarterclayton

Given that you're the author of the test annotation mechanism, I'm guessing you should be involved in its relocation.

@marun
Copy link
Author

marun commented Aug 7, 2020

/test gcp-e2e-kubernetes

@marun
Copy link
Author

marun commented Aug 7, 2020 •
edited

The latest push switches to using ginkgo to run the tests. I learned the hard way that parallel test execution requires that the tests be run with ginkgo vs direct invocation of the test binary. I'm hoping this ensures that the kube e2e job completes within the time limit. If not, it may be necessary to switch to origin's custom ginkgo test runner.

@marun
Copy link
Author

marun commented Aug 7, 2020

Some CI jobs are broken by the CI switch to golang 1.14, which will be fixed by #297.

@openshift-ci-robot openshift-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Aug 7, 2020
@marun
Copy link
Author

marun commented Aug 12, 2020

/retest

marun and others added 2 commits August 12, 2020 18:34
@marun
UPSTREAM: <drop>: Vendor openshift fork of ginkgo
d995108 
While this commit can be dropped at the next rebase, care must be
taken to ensure that the pin to our fork of ginkgo is required to
ensure support for e2e test annotation.
@smarterclayton @marun
UPSTREAM: <carry>: Copy test annotation from origin
a301200
@marun marun force-pushed the kube-e2e branch 2 times, most recently from a01f430 to ae7848d Compare August 13, 2020 05:22
@marun
Copy link
Author

marun commented Aug 13, 2020

/test gcp-e2e-kubernetes

@marun
Copy link
Author

marun commented Aug 13, 2020

/retest

1 similar comment
@marun
Copy link
Author

marun commented Aug 13, 2020

/retest

@marun
Copy link
Author

marun commented Aug 13, 2020

/test

@openshift-ci-robot
Copy link

@marun: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test artifacts
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-azure
  • /test e2e-cmd
  • /test e2e-conformance-k8s
  • /test e2e-gcp
  • /test e2e-gcp-upgrade
  • /test e2e-vsphere
  • /test gcp-e2e-kubernetes
  • /test images
  • /test integration
  • /test unit
  • /test verify
  • /test verify-commits

Use /test all to run the following jobs:

  • pull-ci-openshift-kubernetes-master-artifacts
  • pull-ci-openshift-kubernetes-master-e2e-aws-csi
  • pull-ci-openshift-kubernetes-master-e2e-aws-fips
  • pull-ci-openshift-kubernetes-master-e2e-aws-serial
  • pull-ci-openshift-kubernetes-master-e2e-cmd
  • pull-ci-openshift-kubernetes-master-e2e-conformance-k8s
  • pull-ci-openshift-kubernetes-master-e2e-gcp
  • pull-ci-openshift-kubernetes-master-e2e-gcp-upgrade
  • pull-ci-openshift-kubernetes-master-images
  • pull-ci-openshift-kubernetes-master-integration
  • pull-ci-openshift-kubernetes-master-unit
  • pull-ci-openshift-kubernetes-master-verify
  • pull-ci-openshift-kubernetes-master-verify-commits

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun marun changed the title WIP Enable gcp-e2e-kubernetes job Enable gcp-e2e-kubernetes job Aug 17, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2020
@marun
Copy link
Author

marun commented Aug 17, 2020

/retest

3 similar comments
@marun
Copy link
Author

marun commented Aug 18, 2020

/retest

@marun
Copy link
Author

marun commented Aug 18, 2020

/retest

@marun
Copy link
Author

marun commented Aug 19, 2020

/retest

@mfojtik
Copy link
Member

mfojtik commented Aug 19, 2020

/retest

@marun
Copy link
Author

marun commented Aug 20, 2020

/test gcp-e2e-kubernetes

@marun
Copy link
Author

marun commented Aug 20, 2020

/retest

1 similar comment
@marun
Copy link
Author

marun commented Aug 20, 2020

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 20, 2020 •
edited

@marun: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-csi 71cc68d link /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik
Copy link
Member

mfojtik commented Aug 20, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marun, mfojtik
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@mfojtik
Copy link
Member

mfojtik commented Aug 20, 2020

/override ci/prow/e2e-aws-fips

FIPS is broken and being fixed by newer RHCOS (PR is still pending)

@mfojtik
Copy link
Member

mfojtik commented Aug 20, 2020

merging with button, so we don't have to wait for the FIPS fix to land

@openshift-ci-robot
Copy link

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-fips

In response to this:

/override ci/prow/e2e-aws-fips

FIPS is broken and being fixed by newer RHCOS (PR is still pending)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik merged commit e0b427d into openshift:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sttts sttts Awaiting requested review from sttts

@deads2k deads2k Awaiting requested review from deads2k

@jsafrane jsafrane Awaiting requested review from jsafrane

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mfojtik mfojtik

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marun @openshift-ci-robot @mfojtik @smarterclayton