Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1874919: UPSTREAM: 94423: debugger scheduler plugin #330

Merged
merged 1 commit into from Sep 3, 2020
Merged

bug 1874919: UPSTREAM: 94423: debugger scheduler plugin #330

merged 1 commit into from Sep 3, 2020

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Sep 2, 2020 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:

Exemplary output:

I0902 15:15:17.279872 2157873 scheduling_queue.go:812] About to try and schedule pod default/example
I0902 15:15:17.279908 2157873 scheduler.go:452] Attempting to schedule pod: default/example
I0902 15:15:17.280211 2157873 debugger.go:66] "Dumping node infos" node="ip-10-0-137-0.ec2.internal" requested="[ephemeral-storage=0 cpu=1694m memory=4909Mi pods=0]"
I0902 15:15:17.280277 2157873 debugger.go:66] "Dumping node infos" node="ip-10-0-156-201.ec2.internal" requested="[memory=3478Mi pods=0 ephemeral-storage=0 cpu=894m]"
I0902 15:15:17.280315 2157873 debugger.go:66] "Dumping node infos" node="ip-10-0-165-85.ec2.internal" requested="[cpu=562m memory=3476Mi pods=0 ephemeral-storage=0]"
I0902 15:15:17.280365 2157873 debugger.go:66] "Dumping node infos" node="ip-10-0-143-172.ec2.internal" requested="[cpu=627m memory=3462Mi pods=0 ephemeral-storage=0]"
I0902 15:15:17.280432 2157873 debugger.go:66] "Dumping node infos" node="ip-10-0-157-248.ec2.internal" requested="[cpu=1894m memory=5849Mi pods=0 ephemeral-storage=0]"
I0902 15:15:17.280489 2157873 debugger.go:66] "Dumping node infos" node="ip-10-0-168-41.ec2.internal" requested="[cpu=1911m memory=5459Mi pods=0 ephemeral-storage=0]"
I0902 15:15:17.282140 2157873 default_binder.go:51] Attempting to bind default/example to ip-10-0-143-172.ec2.internal
I0902 15:15:17.483962 2157873 cache.go:371] Finished binding for pod efa4a7d4-1393-41dd-a063-e8cc6bb8d6de. Can be expired.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

New debugger scheduler plugin for dumping state of the kube-scheduler (disabled by default)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 2, 2020
@ingvagabund ingvagabund changed the title scheduler: new debugger plugin 1874919: scheduler: new debugger plugin Sep 2, 2020
@ingvagabund ingvagabund changed the title 1874919: scheduler: new debugger plugin bug 1874919: scheduler: new debugger plugin Sep 2, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 2, 2020
@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Bugzilla bug 1874919, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

bug 1874919: scheduler: new debugger plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 2, 2020
@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Bugzilla bug 1874919, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

bug 1874919: scheduler: new debugger plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund changed the title bug 1874919: scheduler: new debugger plugin bug 1874919: UPSTREAM: 94423: debugger scheduler plugin Sep 2, 2020
soltysh
soltysh approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@marun marun mentioned this pull request Sep 2, 2020
Merged
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@marun
Copy link

marun commented Sep 2, 2020

@ingvagabund Unit test failures are legit.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020
@ingvagabund
Copy link
Member Author

@ingvagabund Unit test failures are legit.

@marun updated

@ingvagabund
Copy link
Member Author

Oh, there are more to fix :-|

@ingvagabund
Copy link
Member Author

/retest

soltysh
soltysh approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 514f31a into openshift:master Sep 3, 2020
@openshift-ci-robot
Copy link

@ingvagabund: All pull requests linked via external trackers have merged:

Bugzilla bug 1874919 has been moved to the MODIFIED state.

In response to this:

bug 1874919: UPSTREAM: 94423: debugger scheduler plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the debugger-scheduler-plugin branch September 10, 2020 14:09
@ingvagabund ingvagabund mentioned this pull request Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@damemi damemi Awaiting requested review from damemi

@tbielawa tbielawa Awaiting requested review from tbielawa

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ingvagabund @openshift-ci-robot @openshift-bot @marun @soltysh @openshift-merge-robot