Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1873043: Rebase 1.19.0 #325

Merged
merged 507 commits into from Sep 10, 2020
Merged

Conversation

marun
Copy link

@marun marun commented Sep 1, 2020

  • The verify-commits job will need to be overridden to merge due to the presence of un-prefixed commits in the base kube branch.
  • This repo has been configured to permit merge despite the presence of the do-not-merge/invalid-owners-file label, which is applied due to the presence of upstream kube contributors in OWNERS files that do not belong to the openshift org.
  • Tracking spreadsheet

k8s-ci-robot and others added 30 commits August 4, 2020 18:08
test/e2e: fail test rather than flooding logs if PVC watch is closed prematurely
…ormer

Fix /readyz to contain informer-sync
Mark cloud provider InstanceV2 as experimental and remove provider ID references
Update Cluster Autoscaler version to 1.19.0
Signed-off-by: knight42 <anonymousknight96@gmail.com>
fix: deflake run_kubectl_apply_tests
 - ensure endpoints that have been deleted and are desired are recreated
 despite a possibly out of date endpoint cache
…ing-tracker-fix

Fixing memory leak in EndpointSliceMirroring EndpointSlice tracker
Deflake TestUpdateNodeStatusWithLease - guard cached machineInfo
Add missing ppc64le architecture in the get-kube* scripts
e2e delete namespaces after finish
…Score plugins

The lack of this validation on incoming pods causes unpredictable cluster outcomes
when later calculating affinity results against existing pods (see kubernetes#92714). This fix
quickly addresses the main source where these problems should be caught.

It is unfortunately difficult to add this validation directly to the API server due
to the fact that it may break migrations with existing pods that fail this check. This
is a compromise to address the current issue.
Add the check for test cluster when starting csi proxy
[go1.15] Use errors.As to unwrap net errors
Add LabelSelector validation in Pod Affinity/AntiAffinity Filter and Score plugins
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@marun
Copy link
Author

marun commented Sep 10, 2020

Picked #338 since its merge forced a retest and stripped the override for verify-commits.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 10, 2020
@openshift openshift deleted a comment from openshift-ci-robot Sep 10, 2020
@marun
Copy link
Author

marun commented Sep 10, 2020

/retest

@openshift-ci-robot
Copy link

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • logicalhan
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • sftim
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • justaugustus
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • build/OWNERS
  • cheftako
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • pkg/controller/OWNERS
  • mrbobbytables
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • zacharysarah
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • dims
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • build/OWNERS
    • cmd/OWNERS
    • pkg/OWNERS
    • plugin/OWNERS
    • staging/OWNERS
    • third_party/OWNERS
  • jimangel
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • johnbelamaric
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • kbarnard10
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • onlydole
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • hasheddan
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • cmd/dependencycheck/OWNERS
  • pwittrock
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • spiffxp
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • build/OWNERS
  • bentheelder
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • liggitt
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • castrojo
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • dashpole
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • kbhawkey
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • nikhita
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@sttts
Copy link

sttts commented Sep 10, 2020

/retest

@sttts
Copy link

sttts commented Sep 10, 2020

/override ci/prow/verify-commits
/override ci/prow/e2e-cmd
/lgtm

@sttts sttts removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 10, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@sttts
Copy link

sttts commented Sep 10, 2020

/override ci/prow/verify-commits

@openshift-ci-robot
Copy link

@sttts: Overrode contexts on behalf of sttts: ci/prow/e2e-cmd, ci/prow/verify-commits

In response to this:

/override ci/prow/verify-commits
/override ci/prow/e2e-cmd
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@sttts: Overrode contexts on behalf of sttts: ci/prow/verify-commits

In response to this:

/override ci/prow/verify-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 0d5808e into openshift:master Sep 10, 2020
@openshift-ci-robot
Copy link

@marun: All pull requests linked via external trackers have merged:

Bugzilla bug 1873043 has been moved to the MODIFIED state.

In response to this:

Bug 1873043: Rebase 1.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet