Bug 1875841: watch-termination: fix deletion race and write non-graceful message also to termination.log #332
Conversation
sttts
commented
Sep 4, 2020
sttts
commented
- the loop creating the event was racing with the code touching the new .terminating file
- the event message lacked the hostname
- the termination.log file lacked the warning about the non-graceful termination which made it hard to follow.
openshift-ci-robot
added
the
approved
sttts
force-pushed
the
sttts-watch-termination-improvements
branch
from
af98ac4
to
114408e
Compare
sttts
changed the title
| return false, nil | ||
| } | ||
|
|
||
| select { | ||
| case <-termCh: | ||
| default: | ||
| klog.Infof("Deleting old termination lock file %q", *terminationLock) | ||
| os.Remove(*terminationLock) |
There was a problem hiding this comment.
these lines were executed when the event was successfully created. But the touch command few lines below would conflict with this. We have to delete first, then touch.
openshift-ci-robot
added
bugzilla/severity-high
|
@sttts: This pull request references Bugzilla bug 1875841, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@sttts: This pull request references Bugzilla bug 1875841, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
sttts
force-pushed
the
sttts-watch-termination-improvements
branch
from
114408e
to
a6929ff
Compare
…-graceful message also to termination.log
sttts
force-pushed
the
sttts-watch-termination-improvements
branch
from
a6929ff
to
db98f0f
Compare
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sttts: All pull requests linked via external trackers have merged: Bugzilla bug 1875841 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
