Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1875194: UPSTREAM: 94609: Use namespace flag passed to RunKubectl* methods #334

Merged
merged 2 commits into from Sep 12, 2020
Merged

Bug 1875194: UPSTREAM: 94609: Use namespace flag passed to RunKubectl* methods #334

merged 2 commits into from Sep 12, 2020

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Sep 8, 2020

/assign @marun

I wasn't sure if you want to have a separate commit to remove 5bb5b37 if so, lemme know.

@openshift-ci-robot
Copy link

@soltysh: This pull request references Bugzilla bug 1875194, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1875194: UPSTREAM: 94609: Add missing --namespace flag to kubectl e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 8, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@soltysh soltysh changed the title Bug 1875194: UPSTREAM: 94609: Add missing --namespace flag to kubectl e2e Bug 1875194: UPSTREAM: 95609: Use namespace flag passed to RunKubectl* methods Sep 8, 2020
@marun
Copy link

marun commented Sep 8, 2020

@soltysh I suggest adding a separate <drop> commit that reverts the skips. I've already removed the commit that added the skips in the 1.19.0 rebase PR in favor of a test annotation rule that references a bz (which I should have done in the first place):

https://bugzilla.redhat.com/show_bug.cgi?id=1875194

@soltysh soltysh changed the title Bug 1875194: UPSTREAM: 95609: Use namespace flag passed to RunKubectl* methods Bug 1875194: UPSTREAM: 94609: Use namespace flag passed to RunKubectl* methods Sep 11, 2020
@soltysh soltysh force-pushed the bug1875194 branch 2 times, most recently from bb9724d to 96c32ff Compare September 11, 2020 13:37
@marun
Copy link

marun commented Sep 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marun
Copy link

marun commented Sep 11, 2020

/retest

The SNI unit tests are flakey. :(

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 71a2411 into openshift:master Sep 12, 2020
@openshift-ci-robot
Copy link

@soltysh: All pull requests linked via external trackers have merged:

Bugzilla bug 1875194 has been moved to the MODIFIED state.

In response to this:

Bug 1875194: UPSTREAM: 94609: Use namespace flag passed to RunKubectl* methods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh deleted the bug1875194 branch September 14, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@marun marun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@soltysh @openshift-ci-robot @marun @openshift-bot @openshift-merge-robot