Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1873043: Enable k8s-e2e-gcp-serial #337

Merged
merged 1 commit into from Sep 12, 2020
Merged

Bug 1873043: Enable k8s-e2e-gcp-serial #337

merged 1 commit into from Sep 12, 2020

Conversation

marun
Copy link

@marun marun commented Sep 8, 2020 •
edited

Using the 1.19.x catchall bz to reflect the importance of this PR to future rebasing efforts.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2020
@marun
Copy link
Author

marun commented Sep 9, 2020

/test k8s-e2e-gcp

@marun marun requested review from sttts, mfojtik and deads2k and removed request for bparees September 9, 2020 02:07
@marun
Copy link
Author

marun commented Sep 9, 2020

/retest

@marun marun changed the title WIP Enable k8s-e2e-serial WIP Enable k8s-e2e-gcp-serial Sep 9, 2020
@marun
Copy link
Author

marun commented Sep 9, 2020

/retest

@marun
Copy link
Author

marun commented Sep 10, 2020

/retest

@marun marun changed the title WIP Enable k8s-e2e-gcp-serial Enable k8s-e2e-gcp-serial Sep 10, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2020
@marun
Copy link
Author

marun commented Sep 10, 2020

/retest

@marun marun changed the title Enable k8s-e2e-gcp-serial WIP Enable k8s-e2e-gcp-serial Sep 10, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2020
@marun
Copy link
Author

marun commented Sep 10, 2020 •
edited

I've included these changes in the rebase PR (#325) since the job is optional anyway. This PR is now just a testbed to determine when it's safe to make the job mandatory.

@marun
UPSTREAM: <carry>: Enable k8s-e2e-serial
6d10d24 
This commit should be squashed with
UPSTREAM: <carry>: Build openshift-compatible e2e binary
@marun marun changed the title WIP Enable k8s-e2e-gcp-serial Enable k8s-e2e-gcp-serial Sep 10, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2020
@marun marun changed the title Enable k8s-e2e-gcp-serial Bug 1873043: Enable k8s-e2e-gcp-serial Sep 10, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 10, 2020
@openshift-ci-robot
Copy link

@marun: This pull request references Bugzilla bug 1873043, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1873043: Enable k8s-e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@marun: This pull request references Bugzilla bug 1873043, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1873043: Enable k8s-e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun
Copy link
Author

marun commented Sep 10, 2020

/retest

1 similar comment
@marun
Copy link
Author

marun commented Sep 11, 2020

/retest

@marun marun mentioned this pull request Sep 11, 2020
Merged
@sttts
Copy link

sttts commented Sep 11, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 11, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 12, 2020
Merged
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e6c224a into openshift:master Sep 12, 2020
@openshift-ci-robot
Copy link

@marun: All pull requests linked via external trackers have merged:

Bugzilla bug 1873043 has been moved to the MODIFIED state.

In response to this:

Bug 1873043: Enable k8s-e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 16, 2020
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 3, 2020
Merged
12 tasks
@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

@mfojtik mfojtik Awaiting requested review from mfojtik

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marun @openshift-ci-robot @sttts @openshift-bot @openshift-merge-robot