Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1878163: Build with golang 1.15 #348

Merged
merged 3 commits into from Sep 18, 2020
Merged

Bug 1878163: Build with golang 1.15 #348

merged 3 commits into from Sep 18, 2020

Conversation

marun
Copy link

@marun marun commented Sep 10, 2020

No description provided.

@marun marun mentioned this pull request Sep 11, 2020
Merged
@marun marun changed the title Build with golang 1.15 Bug 1878163: Build with golang 1.15 Sep 11, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 11, 2020
@openshift-ci-robot
Copy link

@marun: This pull request references Bugzilla bug 1878163, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1878163: Build with golang 1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 11, 2020
@marun
Copy link
Author

marun commented Sep 14, 2020

/retest

@marun
Copy link
Author

marun commented Sep 14, 2020

This branch is now building with golang 1.15 so ci should be capable of passing.

@marun marun force-pushed the golang-1.15 branch 2 times, most recently from 28e625d to 412c18b Compare September 14, 2020 04:26
This was referenced Sep 14, 2020
Merged
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 14, 2020
Merged
@marun
Copy link
Author

marun commented Sep 15, 2020

/retest

3 similar comments
@marun
Copy link
Author

marun commented Sep 15, 2020

/retest

@marun
Copy link
Author

marun commented Sep 16, 2020

/retest

@marun
Copy link
Author

marun commented Sep 16, 2020

/retest

@yselkowitz
Copy link

FYI there is no golang-1.15 for RHEL 7 yet, only for RHEL 8. As the RPM is built for both, this needs to be kept in mind.

@marun
Copy link
Author

marun commented Sep 16, 2020

/retest

@marun marun mentioned this pull request Sep 16, 2020
Closed
@marun
Copy link
Author

marun commented Sep 17, 2020

/retest

@marun
Copy link
Author

marun commented Sep 17, 2020

/test unit

@marun
Copy link
Author

marun commented Sep 17, 2020

Unit tests are chronically racey.

@marun
Copy link
Author

marun commented Sep 17, 2020

I can't replicate the verify failure locally, ocp wins again. Given that this was working up until this week, maybe the ci migration from 3.x to 4.x is to blame?

@marun
Copy link
Author

marun commented Sep 17, 2020

/retest

1 similar comment
@marun
Copy link
Author

marun commented Sep 17, 2020

/retest

@marun
Copy link
Author

marun commented Sep 17, 2020

/retest

@marun
UPSTREAM: <carry>: (squash) Stop installing recent bash and protoc fr…
583e078 
…om source

Remove installation from source of recent bash and protoc 3.0.0 now
that both are available on the ci build root image.

Squash with UPSTREAM: <carry>: Enable build, test and verify
@marun
Copy link
Author

marun commented Sep 18, 2020

/retest

@marun marun requested a review from tnozicka September 18, 2020 05:06
@marun
Copy link
Author

marun commented Sep 18, 2020

/retest

@openshift-ci-robot
Copy link

@marun: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/k8s-e2e-gcp-serial 583e078 link /test k8s-e2e-gcp-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts
Copy link

sttts commented Sep 18, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7f9e863 into openshift:master Sep 18, 2020
@openshift-ci-robot
Copy link

@marun: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1878163 has not been moved to the MODIFIED state.

In response to this:

Bug 1878163: Build with golang 1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun marun deleted the golang-1.15 branch September 18, 2020 17:06
This was referenced Sep 19, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@sttts sttts Awaiting requested review from sttts

@tnozicka tnozicka Awaiting requested review from tnozicka

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marun @openshift-ci-robot @yselkowitz @sttts @openshift-merge-robot