UPSTREAM: <carry>: add metric forwarding for check-endpoints so it ca… #359
Conversation
sanchezl
force-pushed
the
metric-forward
branch
from
c075994
to
050f072
Compare
sanchezl
force-pushed
the
metric-forward
branch
2 times, most recently
from
70563dd
to
5f70208
Compare
|
@sanchezl: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@sanchezl: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…n be scraped There is no way to open a port on a master machine. It is different for every platform and the install team doesn't even know all the spots to do it. Since our check-endpoints is directly connected to a kube-apiserver, we can expose a handler on the kube-apiserver does a GET to the correct port with a client cert identified user to retrieve metrics and simply replay the result back to the client.t
sanchezl
force-pushed
the
metric-forward
branch
from
5f70208
to
72b18fd
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanchezl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-fips |
|
@sanchezl: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
@sanchezl: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There is no way to open a port on a master machine. It is different for every platform and
the install team doesn't even know all the spots to do it. Since our check-endpoints is directly
connected to a kube-apiserver, we can expose a handler on the kube-apiserver does a GET to
the correct port with a client cert identified user to retrieve metrics and simply replay the
result back to the client.