Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1879057: e2e: skip write/read cache when running Block-mode RWX PVC tests #378

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

nixpanic
Copy link
Member

Backport kubernetes#94881 so that CSI Certification Suite tests can work on RWX Block-mode PVCs.

Request-review: @openshift/storage
Bug: RHBZ#1879057

…in pod.Config

For testing certain features, the BusyBox image does not provide all the
tools that are needed. Notably 'dd' from BusyBox does not support
direct-io that is required for skipping caches while doing writes and
reads on a Block-mode PVC attached to different nodes.
… block PVCs

By passing "oflag=nocache" and "iflag=direct", caching should be
disabled while writing/reading with "dd" to a block device. The
TestConcurrentAccessToSingleVolume() test is known to fail with certain
storage backends (like Ceph RBD) when caching is enabled.

The default BusyBox image used for testing does not support the required
options for "dd". So instead of running with BusyBox, run the test with
a Debian image.
@nixpanic nixpanic changed the title UPSTREAM: 94881: e2e: skip write/read cache when running Block-mode RWX PVC tests Bug 1879057: e2e: skip write/read cache when running Block-mode RWX PVC tests Sep 29, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 29, 2020
@openshift-ci-robot
Copy link

@nixpanic: This pull request references Bugzilla bug 1879057, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1879057: e2e: skip write/read cache when running Block-mode RWX PVC tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 29, 2020
@jsafrane
Copy link

jsafrane commented Oct 1, 2020

/retest
/lgtm
/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 1, 2020
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1879057, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/retest
/lgtm
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member

/retest

2 similar comments
@bertinatto
Copy link
Member

/retest

@bertinatto
Copy link
Member

/retest

@mfojtik
Copy link

mfojtik commented Oct 2, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mfojtik, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit db1fc96 into openshift:master Oct 2, 2020
@openshift-ci-robot
Copy link

@nixpanic: All pull requests linked via external trackers have merged:

Bugzilla bug 1879057 has been moved to the MODIFIED state.

In response to this:

Bug 1879057: e2e: skip write/read cache when running Block-mode RWX PVC tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nixpanic added a commit to nixpanic/origin that referenced this pull request Oct 5, 2020
…WX PVC tests

Vendor the Kubernetes changes from openshift/kubernetes#378.

Fixes: RHBZ#1879057
marun pushed a commit to marun/origin that referenced this pull request Nov 19, 2020
…WX PVC tests

Vendor the Kubernetes changes from openshift/kubernetes#378.

Fixes: RHBZ#1879057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants