Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPCLOUD-914: UPSTREAM: 94526: Add vCenter info metric #447

Merged

Conversation

Danil-Grigorev
Copy link

Upstream cherry-pick of kubernetes#94526

Metric provides information about used vCenter version
for every connected vCenter host. Metric displays the info about vCenter version, build and hostname

image

What type of PR is this?
/kind cherry-pick

What this PR does / why we need it:

Currently, the vCenter version is unknown to the Kubernetes cluster. Adding this metric will report the existing vCenter version for every connected host defined in vsphere.conf file.

Which issue(s) this PR fixes:

Fixes kubernetes#94651

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add a new `vSphere` metric: `cloudprovider_vsphere_vcenter_versions`. It's content show `vCenter` hostnames with the associated server version.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@openshift-ci-robot
Copy link

@Danil-Grigorev: The label(s) kind/cherry-pick cannot be applied, because the repository doesn't have them

In response to this:

Upstream cherry-pick of kubernetes#94526

Metric provides information about used vCenter version
for every connected vCenter host. Metric displays the info about vCenter version, build and hostname

image

What type of PR is this?
/kind cherry-pick

What this PR does / why we need it:

Currently, the vCenter version is unknown to the Kubernetes cluster. Adding this metric will report the existing vCenter version for every connected host defined in vsphere.conf file.

Which issue(s) this PR fixes:

Fixes kubernetes#94651

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add a new `vSphere` metric: `cloudprovider_vsphere_vcenter_versions`. It's content show `vCenter` hostnames with the associated server version.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Danil-Grigorev Danil-Grigorev changed the title OCPCLOUD-914: upstream 94526 - Add vCenter info metric OCPCLOUD-914: UPSTREAM: 94526: Add vCenter info metric Nov 11, 2020
Metric provides information about used vCenter version
for every connected vCenter host.
@Danil-Grigorev
Copy link
Author

/retest

1 similar comment
@Danil-Grigorev
Copy link
Author

/retest

@sttts
Copy link

sttts commented Nov 18, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9863a4d into openshift:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vSphere metrics to report vCenter version
5 participants