Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "UPSTREAM: revert: <drop>: don't use dynamic tokens for KCM" #459

Merged
merged 1 commit into from Nov 17, 2020

Conversation

marun
Copy link

@marun marun commented Nov 16, 2020

This reverts #448

Many jobs started failing after this merged due to token issues with KCM, as per https://bugzilla.redhat.com/show_bug.cgi?id=1897604

WIP until the affected jobs pass cluster bot multi-PR testing.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2020
… tokens for KCM"

This reverts commit ec633c2.

Many jobs started failing after this merged due to token issues with
KCM, as per https://bugzilla.redhat.com/show_bug.cgi?id=1897604
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@sjenning
Copy link

can confirm the revert fixes KCM authentication issue
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sjenning sjenning changed the title WIP Revert "UPSTREAM: revert: <drop>: don't use dynamic tokens for KCM" Revert "UPSTREAM: revert: <drop>: don't use dynamic tokens for KCM" Nov 17, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2020
@sjenning
Copy link

/retest

@JAORMX
Copy link

JAORMX commented Nov 17, 2020

/test k8s-e2e-gcp

@p0lyn0mial
Copy link

/test e2e-aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants