Bug 1897361: ctrcfg_test: Wait for our prior target config #2229

rphillips · 2020-11-13T21:09:46Z

Waiting for the previous MC isn't right here; we're deleting
a config and so what we want to wait for is the previous pool
target.

Drop the racy sleep().

- What I did

- How to verify it

- Description for the changelog

Waiting for the previous MC isn't right here; we're deleting a config and so what we want to wait for is the previous pool target. Drop the racy `sleep()`.

openshift-ci-robot · 2020-11-13T23:27:28Z

@rphillips: This pull request references Bugzilla bug 1897361, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1897361: ctrcfg_test: Wait for our prior target config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice

=== RUN   TestContainerRuntimeConfigLogLevel
--- PASS: TestContainerRuntimeConfigLogLevel (553.14s)

This has fixed it, but still not a great idea of why it happened in the first place, but this PR also makes the ctrcfg test more inline with the mcd tests.

kikisdeliveryservice · 2020-11-14T00:33:22Z

/skip

kikisdeliveryservice · 2020-11-14T01:31:37Z

well looks like gcp-op isn't the only problem with ci today... sigh

all required tests are failing on all prs.

rphillips · 2020-11-14T20:59:29Z

/retest

LorbusChris · 2020-11-15T00:52:23Z

/retest

LorbusChris · 2020-11-15T06:36:06Z

/retest

sinnykumari · 2020-11-16T11:18:36Z

/retest

LorbusChris · 2020-11-16T13:39:22Z

TestDontDeleteRPMFiles keeps on timing out :(
/retest

cgwalters · 2020-11-16T14:20:48Z

TestDontDeleteRPMFiles keeps on timing out :(

I'm pretty sure that's the overall test timeout, not that specific test. See
openshift/cluster-dns-operator#213
for a hopeful fix for reboot speed in 4.7/master.

umohnani8 · 2020-11-16T14:48:17Z

LGTM

kikisdeliveryservice · 2020-11-16T17:50:21Z

/lgtm

kikisdeliveryservice · 2020-11-16T17:50:26Z

/skip

openshift-bot · 2020-11-17T18:26:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-17T20:10:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-17T20:49:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

yuqi-zhang · 2020-11-17T23:20:11Z

/retest

AWS should be better

rphillips · 2020-11-18T02:33:48Z

/test e2e-gcp-op

openshift-bot · 2020-11-18T03:06:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sinnykumari · 2020-11-18T07:27:08Z

/test e2e-gcp-op

openshift-bot · 2020-11-18T10:02:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-18T14:35:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-18T15:40:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-18T16:58:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

kikisdeliveryservice · 2020-11-18T18:03:31Z

openshift/cluster-dns-operator#213 (comment) merged (thanks to @cgwalters !), but it'll probably take another run or two before it's in... 👍

almost there!

rphillips · 2020-11-18T20:09:35Z

/test e2e-gcp-op

rphillips · 2020-11-18T21:14:29Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2020-11-18T21:14:30Z

@rphillips: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice · 2020-11-18T22:00:14Z

I'm seeing:

2020/11/18 21:55:51 Pod e2e-gcp-op-test succeeded after 1h0m30s EEEEEEEP!!!!! 😃

kikisdeliveryservice · 2020-11-18T22:25:45Z

It's.. running the tests... AGAIN 😭

It did officially pass gcp-op tho!! https://prow.ci.openshift.org/pr-history/?org=openshift&repo=machine-config-operator&pr=2229

kikisdeliveryservice · 2020-11-19T00:12:52Z

e2e-gcp-op is passing again so waiting for this to officially merge (https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/2229/pull-ci-openshift-machine-config-operator-master-e2e-gcp-op/1329185639261802496):

2020/11/19 00:07:24 Container test in pod e2e-gcp-op-test completed successfully
2020/11/19 00:07:24 Pod e2e-gcp-op-test succeeded after 1h3m7s
2020/11/19 00:07:24 Executing pod "e2e-gcp-op-gather-must-gather"
2020/11/19 00:07:42 Container cp-secret-wrapper in pod e2e-gcp-op-gather-must-gather completed successfully

openshift-merge-robot · 2020-11-19T00:42:42Z

@rphillips: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/okd-e2e-aws	`b818d76`	link	`/test okd-e2e-aws`
ci/prow/e2e-ovn-step-registry	`b818d76`	link	`/test e2e-ovn-step-registry`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kikisdeliveryservice · 2020-11-19T00:45:01Z

gcp-op passed(!!!) aws-serial did pass once but now failed so let's try again.

kikisdeliveryservice · 2020-11-19T00:47:10Z

On second thought this PR is only updating our test in gcp-op (tests/e2e/...) and has passed 2x now so the fix works. I'm not going to block on aws-serial as it will never be affected by this pr.

/override ci/prow/e2e-aws-serial

openshift-ci-robot · 2020-11-19T00:47:40Z

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-aws-serial

In response to this:

On second thought this PR is only updating our test in gcp-op (tests/e2e/...) and has passed 2x now so the fix works. I'm not going to block on aws-serial as it will never be affected by this pr.

/override ci/prow/e2e-aws-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-11-19T00:49:35Z

@rphillips: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2229

Bugzilla bug 1897361 has been moved to the MODIFIED state.

In response to this:

Bug 1897361: ctrcfg_test: Wait for our prior target config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-11-19T00:49:53Z

@rphillips: new pull request created: #2239

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ctrcfg_test: Wait for our prior target config

b818d76

Waiting for the previous MC isn't right here; we're deleting a config and so what we want to wait for is the previous pool target. Drop the racy `sleep()`.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2020

openshift-ci-robot requested review from ashcrow and kikisdeliveryservice November 13, 2020 21:10

rphillips closed this Nov 13, 2020

kikisdeliveryservice reopened this Nov 13, 2020

rphillips changed the title ~~WIP: ctrcfg_test: Wait for our prior target config [single commit]~~ WIP: ctrcfg_test: Wait for our prior target config Nov 13, 2020

kikisdeliveryservice changed the title ~~WIP: ctrcfg_test: Wait for our prior target config~~ Bug 1897361: ctrcfg_test: Wait for our prior target config Nov 13, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 13, 2020

kikisdeliveryservice mentioned this pull request Nov 13, 2020

Bug 1897361: ctrcfg_test: Wait for our prior target config #2227

Closed

kikisdeliveryservice approved these changes Nov 13, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020

kikisdeliveryservice assigned umohnani8 and rphillips Nov 14, 2020

ashcrow approved these changes Nov 16, 2020

View reviewed changes

openshift-ci-robot assigned kikisdeliveryservice Nov 16, 2020

kikisdeliveryservice added the team-mco label Nov 18, 2020

kikisdeliveryservice mentioned this pull request Nov 18, 2020

Bug 1895360: pkg/daemon: don't delete a file if its replaced with a dropin #2196

Merged

kikisdeliveryservice mentioned this pull request Nov 19, 2020

Add kubevirt platform #2098

Merged

openshift-merge-robot merged commit 806f77e into openshift:master Nov 19, 2020

openshift-cherrypick-robot mentioned this pull request Nov 19, 2020

[release-4.6] Bug 1899368: ctrcfg_test: Wait for our prior target config #2239

Merged

haircommander mentioned this pull request Nov 19, 2020

Bug 1875181: [4.4] crio: bump to v1.17.5 #2056

Closed

Bug 1897361: ctrcfg_test: Wait for our prior target config #2229

Bug 1897361: ctrcfg_test: Wait for our prior target config #2229

Conversation

rphillips commented Nov 13, 2020

openshift-ci-robot commented Nov 13, 2020

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

kikisdeliveryservice commented Nov 14, 2020

kikisdeliveryservice commented Nov 14, 2020 • edited

rphillips commented Nov 14, 2020

LorbusChris commented Nov 15, 2020

LorbusChris commented Nov 15, 2020

sinnykumari commented Nov 16, 2020

LorbusChris commented Nov 16, 2020

cgwalters commented Nov 16, 2020

umohnani8 commented Nov 16, 2020

kikisdeliveryservice commented Nov 16, 2020

kikisdeliveryservice commented Nov 16, 2020

openshift-bot commented Nov 17, 2020

openshift-bot commented Nov 17, 2020

openshift-bot commented Nov 17, 2020

yuqi-zhang commented Nov 17, 2020

rphillips commented Nov 18, 2020

openshift-bot commented Nov 18, 2020

sinnykumari commented Nov 18, 2020

openshift-bot commented Nov 18, 2020

openshift-bot commented Nov 18, 2020

openshift-bot commented Nov 18, 2020

openshift-bot commented Nov 18, 2020

kikisdeliveryservice commented Nov 18, 2020

rphillips commented Nov 18, 2020

rphillips commented Nov 18, 2020

openshift-cherrypick-robot commented Nov 18, 2020

kikisdeliveryservice commented Nov 18, 2020

kikisdeliveryservice commented Nov 18, 2020 • edited

kikisdeliveryservice commented Nov 19, 2020

openshift-merge-robot commented Nov 19, 2020 • edited

kikisdeliveryservice commented Nov 19, 2020 • edited

kikisdeliveryservice commented Nov 19, 2020

openshift-ci-robot commented Nov 19, 2020

openshift-ci-robot commented Nov 19, 2020

openshift-cherrypick-robot commented Nov 19, 2020

kikisdeliveryservice commented Nov 14, 2020 •

edited

kikisdeliveryservice commented Nov 18, 2020 •

edited

openshift-merge-robot commented Nov 19, 2020 •

edited

kikisdeliveryservice commented Nov 19, 2020 •

edited