New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports: 96217 and 95725 #479
Conversation
…efault timeout for SubjectAccessReview client previously no timeout was set. Requests without explicit timeout might potentially hang forever and lead to starvation of the application.
44f669b
to
8b432c7
Compare
/assign @sttts |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: p0lyn0mial The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8b432c7
to
6794911
Compare
6794911
to
a6b4d3e
Compare
/hold we should get these commits once the rebase PR lands |
/retest |
@p0lyn0mial: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@p0lyn0mial: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close already backported |
@p0lyn0mial: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
These PRs set a default timeout for delegated authz/authn calls. Previously no timeout was set. Requests without explicit timeout might potentially hang forever and lead to starvation of the application.