Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1908389: UPSTREAM: 97455: Use network.Interface.VirtualMachine.ID to get the binded VM #497

Conversation

Miciah
Copy link

@Miciah Miciah commented Dec 22, 2020

What type of PR is this?

/kind bug
/kind failing-test
/kind regression

What this PR does / why we need it:

It fixes configuring service load balancers on Azure.

Which issue(s) this PR fixes:
Fixes BZ#1908389.

Special notes for your reviewer:

None.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Dec 22, 2020
@openshift-ci-robot
Copy link

@Miciah: The label(s) kind/regression cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind bug
/kind failing-test
/kind regression

What this PR does / why we need it:

It fixes configuring service load balancers on Azure.

Which issue(s) this PR fixes:
Fixes BZ#1908389.

Special notes for your reviewer:

None.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@Miciah: This pull request references Bugzilla bug 1908389, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1908389: UPSTREAM: 97455: Use network.Interface.VirtualMachine.ID to get the binded VM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 22, 2020
@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Dec 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Miciah
To complete the pull request process, please assign marun after the PR has been reviewed.
You can assign the PR to them by writing /assign @marun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@staebler
Copy link

/test e2e-azure

@deads2k
Copy link

deads2k commented Dec 22, 2020

Picking kubernetes#97455 seems reasonable. If it works, be sure to comment on the original and backport it to kube 1.20.

@wking
Copy link
Member

wking commented Dec 22, 2020

verify-commits wants the UPSTREAM: 97455: prefix on the commit message too, and 91eef64 doesn't have it at the moment. Probably not worth addressing until the Azure job wraps up.

@openshift-ci
Copy link

openshift-ci bot commented Dec 22, 2020

@Miciah: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-commits 91eef64 link /test verify-commits
ci/prow/k8s-e2e-gcp 91eef64 link /test k8s-e2e-gcp
ci/prow/e2e-aws-fips 91eef64 link /test e2e-aws-fips
ci/prow/e2e-azure 91eef64 link /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Miciah
Copy link
Author

Miciah commented Jan 4, 2021

/close
Superseded by #500.

@openshift-ci-robot
Copy link

@Miciah: Closed this PR.

In response to this:

/close
Superseded by #500.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@Miciah: This pull request references Bugzilla bug 1908389. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1908389: UPSTREAM: 97455: Use network.Interface.VirtualMachine.ID to get the binded VM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants