Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1908389: UPSTREAM: 97635: Cherry pick 443 and 448 from cloud provider azure #500

Merged

Conversation

sgreene570
Copy link

What type of PR is this?

/kind bug
/kind failing-test
/kind regression

What this PR does / why we need it:

It fixes configuring service load balancers on Azure.

Which issue(s) this PR fixes:

Fixes BZ#1908389.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
None

This is a cherry pick of upstream kubernetes#97635, which unblocks our azure CI as seen in #499.

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 4, 2021
@openshift-ci-robot
Copy link

@sgreene570: The label(s) kind/regression cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind bug
/kind failing-test
/kind regression

What this PR does / why we need it:

It fixes configuring service load balancers on Azure.

Which issue(s) this PR fixes:

Fixes BZ#1908389.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
None

This is a cherry pick of upstream kubernetes#97635, which unblocks our azure CI as seen in #499.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. labels Jan 4, 2021
@openshift-ci-robot
Copy link

@sgreene570: This pull request references Bugzilla bug 1908389, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1908389: UPSTREAM: 97635: Cherry pick 443 and 448 from cloud provider azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 4, 2021
@sgreene570
Copy link
Author

/cc @Miciah @wking @staebler @michaelgugino @deads2k @sdodson

@sgreene570
Copy link
Author

/test e2e-azure

@deads2k
Copy link

deads2k commented Jan 4, 2021

picking opened and lgtm'd fixes upstream is a good idea. Please ensure those upstreams are cherrypicked to 1.20. Remind me on slack and I can help when it comes back up.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@sdodson sdodson mentioned this pull request Jan 4, 2021
@sgreene570
Copy link
Author

e2e-azure passed
/retest

@sgreene570
Copy link
Author

/retest

@Miciah
Copy link

Miciah commented Jan 5, 2021

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2021
@michaelgugino
Copy link

/test e2e-azure-serial

@openshift-ci-robot
Copy link

@michaelgugino: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test artifacts
  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-selfupgrade
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-azure-upgrade
  • /test e2e-gcp
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-vsphere
  • /test images
  • /test integration
  • /test k8s-e2e-conformance-aws
  • /test k8s-e2e-gcp
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-commits

Use /test all to run the following jobs:

  • pull-ci-openshift-kubernetes-master-e2e-agnostic-cmd
  • pull-ci-openshift-kubernetes-master-e2e-aws-csi
  • pull-ci-openshift-kubernetes-master-e2e-aws-fips
  • pull-ci-openshift-kubernetes-master-e2e-aws-serial
  • pull-ci-openshift-kubernetes-master-e2e-gcp
  • pull-ci-openshift-kubernetes-master-e2e-gcp-upgrade
  • pull-ci-openshift-kubernetes-master-images
  • pull-ci-openshift-kubernetes-master-integration
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp
  • pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-master-unit
  • pull-ci-openshift-kubernetes-master-verify
  • pull-ci-openshift-kubernetes-master-verify-commits

In response to this:

/test e2e-azure-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelgugino
Copy link

/test e2e-azure-upgrade

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@michaelgugino
Copy link

michaelgugino commented Jan 5, 2021

From upgrade run:

level=error msg=Cluster operator ingress Degraded is True with IngressControllersDegraded: Some ingresscontrollers are degraded: ingresscontroller "default" is degraded: DegradedConditions: One or more other status conditions indicate a degraded state: CanaryChecksSucceeding=False (CanaryChecksRepetitiveFailures: Canary route checks for the default ingress controller are failing)

level=error msg=Cluster operator ingress Degraded is True with IngressControllersDegraded: Some ingresscontrollers are degraded: ingresscontroller "default" is degraded: DegradedConditions: One or more other status conditions indicate a degraded state: CanaryChecksSucceeding=False (CanaryChecksRepetitiveFailures: Canary route checks for the default ingress controller are failing)

@sgreene570
Copy link
Author

From upgrade run:

level=error msg=Cluster operator ingress Degraded is True with IngressControllersDegraded: Some ingresscontrollers are degraded: ingresscontroller "default" is degraded: DegradedConditions: One or more other status conditions indicate a degraded state: CanaryChecksSucceeding=False (CanaryChecksRepetitiveFailures: Canary route checks for the default ingress controller are failing)

The current in tree azure provider is broken, so it is expected that a cluster would not be able to launch with a current 4.7 nightly on azure, thus failing the upgrade test. I have manually kicked off an upgrade test from 4.6 via cluster bot in place of this job to ensure that this PR works for upgrades.

@sgreene570
Copy link
Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jan 6, 2021

/skip

@sdodson
Copy link
Member

sdodson commented Jan 6, 2021

/override ci/prow/e2e-azure-upgrade
This is failing because the install of older versions doesn't work, once we fix the install we expect upgrade to start working after that build has been accepted.

@openshift-ci-robot
Copy link

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-azure-upgrade

In response to this:

/override ci/prow/e2e-azure-upgrade
This is failing because the install of older versions doesn't work, once we fix the install we expect upgrade to start working after that build has been accepted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelgugino
Copy link

From upgrade run:

level=error msg=Cluster operator ingress Degraded is True with IngressControllersDegraded: Some ingresscontrollers are degraded: ingresscontroller "default" is degraded: DegradedConditions: One or more other status conditions indicate a degraded state: CanaryChecksSucceeding=False (CanaryChecksRepetitiveFailures: Canary route checks for the default ingress controller are failing)

The current in tree azure provider is broken, so it is expected that a cluster would not be able to launch with a current 4.7 nightly on azure, thus failing the upgrade test. I have manually kicked off an upgrade test from 4.6 via cluster bot in place of this job to ensure that this PR works for upgrades.

How did the upgrade go?

@sgreene570
Copy link
Author

sgreene570 commented Jan 6, 2021

How did the upgrade go?

The cluster-bot test upgrade command wasn't getting me what I wanted (for some reason cluster bot was insisting on using a 4.7 initial release for the upgrade run rather than 4.6). Running an upgrade manually from 4.6.9 to a 4.7 build with this PR on azure right now. Will report back. @michaelgugino

@sgreene570
Copy link
Author

@michaelgugino @sdodson manual upgrade from 4.6.9 to 4.7 built with this PR succeeded on azure.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5bb3eec into openshift:master Jan 7, 2021
@openshift-ci-robot
Copy link

@sgreene570: All pull requests linked via external trackers have merged:

Bugzilla bug 1908389 has been moved to the MODIFIED state.

In response to this:

Bug 1908389: UPSTREAM: 97635: Cherry pick 443 and 448 from cloud provider azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants