New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1908389: UPSTREAM: 97635: Cherry pick 443 and 448 from cloud provider azure #500
Bug 1908389: UPSTREAM: 97635: Cherry pick 443 and 448 from cloud provider azure #500
Conversation
@sgreene570: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sgreene570: This pull request references Bugzilla bug 1908389, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-azure |
picking opened and lgtm'd fixes upstream is a good idea. Please ensure those upstreams are cherrypicked to 1.20. Remind me on slack and I can help when it comes back up. /approve |
e2e-azure passed |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-azure-serial |
@michaelgugino: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-azure-upgrade |
/retest Please review the full test history for this PR and help us cut down flakes. |
From upgrade run:
level=error msg=Cluster operator ingress Degraded is True with IngressControllersDegraded: Some ingresscontrollers are degraded: ingresscontroller "default" is degraded: DegradedConditions: One or more other status conditions indicate a degraded state: CanaryChecksSucceeding=False (CanaryChecksRepetitiveFailures: Canary route checks for the default ingress controller are failing) |
The current in tree azure provider is broken, so it is expected that a cluster would not be able to launch with a current 4.7 nightly on azure, thus failing the upgrade test. I have manually kicked off an upgrade test from 4.6 via cluster bot in place of this job to ensure that this PR works for upgrades. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/skip |
/override ci/prow/e2e-azure-upgrade |
@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-azure-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
How did the upgrade go? |
The cluster-bot test upgrade command wasn't getting me what I wanted (for some reason cluster bot was insisting on using a 4.7 initial release for the upgrade run rather than 4.6). Running an upgrade manually from 4.6.9 to a 4.7 build with this PR on azure right now. Will report back. @michaelgugino |
@michaelgugino @sdodson manual upgrade from 4.6.9 to 4.7 built with this PR succeeded on azure. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@sgreene570: All pull requests linked via external trackers have merged: Bugzilla bug 1908389 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/kind failing-test
/kind regression
What this PR does / why we need it:
It fixes configuring service load balancers on Azure.
Which issue(s) this PR fixes:
Fixes BZ#1908389.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
None
This is a cherry pick of upstream kubernetes#97635, which unblocks our azure CI as seen in #499.