Bug 1908880: UPSTREAM: 97980: kubelet: revert checking sandbox deletion #523
Conversation
Revert "Merge pull request kubernetes#92817 from kmala/kubelet" This reverts commit 88512be, reversing changes made to c3b888f.
openshift-ci-robot
requested review from
kikisdeliveryservice,
mrunalp and
rphillips
openshift-ci-robot
added
bugzilla/severity-high
|
@ehashman: This pull request references Bugzilla bug 1908880, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Should this be attached to : https://bugzilla.redhat.com/show_bug.cgi?id=1915085 which I thought was the tracking bug? |
|
I dont think my approval carries any weight in this repo but LGTM. Thanks @ehashman for getting this done so quickly ❤️ |
That one is not assigned to me, I'm new to this so I'm happy to update to whatever is the correct bug :) |
|
I think rhbz#1915085 is a separate bug about creation-time issues, while this reversion is addressing a deletion-time issue. Doesn't really matter though, we can measure impacts of the various symptoms after this lands. |
|
/lgtm |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, rphillips, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
FIPS hit /test e2e-aws-fips |
|
|
|
/test e2e-gcp |
|
Edit: Reported. |
|
Looks like https://bugzilla.redhat.com/show_bug.cgi?id=1896218 maybe? I think the VPCs have been fixed... /retest |
|
re: e2e-aws-fips (1000 role limit), it's been reported and jobs need to be reaped but that's having issues rn. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Another /retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@ehashman: All pull requests linked via external trackers have merged: Bugzilla bug 1908880 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We've had a regression in 1.20 where pod deletion time has significantly increased due to kubernetes#92817. While we investigate the underlying cause, let's revert this to avoid test flakes.
Upstream bug: kubernetes#97288
Upstream PR: kubernetes#97980
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1908880
/cc @rphillips @mrunalp @kikisdeliveryservice