Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOWNSTREAM_OWNERS as preparation for https://github.com/kubernetes/test-infra/pull/20482 #537

Merged

Conversation

sttts
Copy link

@sttts sttts commented Jan 25, 2021

Instead of modifying upstream OWNERS files and to avoid possible conflicts, we will make use of kubernetes/test-infra#20482 to point to DOWNSTREAM_OWNERS instead.

When we have enabled DOWNSTREAM_OWNERS in prow config, we will revert the modifications of OWNERS.

This needs a backport to 4.6, 4.5, 4.4.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
@mfojtik
Copy link
Member

mfojtik commented Jan 25, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Jan 25, 2021

@sttts: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-cmd a383381 link /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 614d551 into openshift:master Jan 25, 2021
@sttts
Copy link
Author

sttts commented Jan 25, 2021

/cherry-pick release-4.6
/cherry-pick release-4.5
/cherry-pick release-4.4

@openshift-cherrypick-robot

@sttts: new pull request created: #540

In response to this:

/cherry-pick release-4.6
/cherry-pick release-4.5
/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Author

sttts commented Jan 25, 2021

/cherry-pick release-4.5

@sttts
Copy link
Author

sttts commented Jan 25, 2021

/cherry-pick release-4.4

@openshift-cherrypick-robot

@sttts: cannot checkout release-4.5: error checking out release-4.5: exit status 1. output: error: pathspec 'release-4.5' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@sttts: cannot checkout release-4.4: error checking out release-4.4: exit status 1. output: error: pathspec 'release-4.4' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Elbehery pushed a commit to Elbehery/kubernetes that referenced this pull request Apr 9, 2021
…-cache

Cherry pick openshift#537 from cloud provider azure: Refresh VM cache when node is not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants