New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prow: allow configuring the filenames used for OWNERS(_ALIASES) #20482
prow: allow configuring the filenames used for OWNERS(_ALIASES) #20482
Conversation
abf0dcb
to
df00caa
Compare
Seventeen tries later I think |
The test-infra/prow/config/config.go Lines 143 to 145 in 351ae39
Can that satisfy your use case? I'd prefer to avoid making the OWNERS file names configurable. I'd rather have consistency across repos so that repo admins can choose whether OWNERS files sourced from other repos should apply (and even allow some to apply while ignoring others). |
@cjwagner no, in the case of a fork that's maintained actively, it's required that the entire codebase be changed (not only vendor) and that sub-directories, etc, in the codebase have reviewers and approvers as needed. |
df00caa
to
373ddd3
Compare
412f316
to
ffbd62f
Compare
When a repository is a fork of an upstream repository with OWNERS, or vendors a repository that also uses OWNERS, it is generally not intended for users who are OWNERS upstream to have rights in the downstream. Furthermore, changing the OWNERS files leads to merge conflicts as changes from upstream are pulled in, which leads to headaches. Allowing users to configure the files used by Prow to denote owners and aliases side-steps this issue. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
ffbd62f
to
aa976bf
Compare
@alvaroaleman updated YAML |
@cjwagner @alvaroaleman PTAL |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add DOWNSTREAM_OWNERS as preparation for kubernetes/test-infra#20482
When a repository is a fork of an upstream repository with OWNERS, or
vendors a repository that also uses OWNERS, it is generally not intended
for users who are OWNERS upstream to have rights in the downstream.
Furthermore, changing the OWNERS files leads to merge conflicts as
changes from upstream are pulled in, which leads to headaches. Allowing
users to configure the files used by Prow to denote owners and aliases
side-steps this issue.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/assign @alvaroaleman @cjwagner