Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.6] Bug 1926262: Prevent GCP e2e tests from triggering a rate limit on the listZone API #556

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #552

/assign smarterclayton

Instead of allowing the cloud provider to guess at the zones that
should be applied for a cluster under test, allow the explicit list
of zones to consider to be passed as a new test context flag -gce-zones.

Only the GCE test cloud provider recognizes this value because only
the GCE test cloud provider makes assumptions about zones for verifying
values, and the default assumptions for GKE do not always match non-GKE
providers.
A number of e2e tests are useful to run after the system has been
disrupted or is in the progress of being disrupted, but the current
suite and test logic blocks progress waiting for all nodes to be
healthy.

By passing -1 to --minStartupPods or --allowed-not-ready-nodes flags
the caller can bypass wait logic before and after test suites that
would prevent running e2e during disruption. This allows use of parts
of the e2e suite during cluster duress to verify that controllers or
components still function.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1920221 has been cloned as Bugzilla bug 1926262. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1926262: Prevent GCP e2e tests from triggering a rate limit on the listZone API

In response to this:

[release-4.6] Bug 1920221: Prevent GCP e2e tests from triggering a rate limit on the listZone API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Feb 8, 2021
@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1920221: Prevent GCP e2e tests from triggering a rate limit on the listZone API [release-4.6] Bug 1926262: Prevent GCP e2e tests from triggering a rate limit on the listZone API Feb 8, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Feb 8, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1926262, which is invalid:

  • expected dependent Bugzilla bug 1920221 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1920221 to target a release in 4.7.0, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1926262: Prevent GCP e2e tests from triggering a rate limit on the listZone API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 8, 2021
@smarterclayton
Copy link

@deads2k @sdodson this is another 4.6 backport which should clear a lot of red out of GCP runs (this logic is used by the latest 4.7 code i'm backporting)

@smarterclayton
Copy link

/retest

@sdodson
Copy link
Member

sdodson commented Feb 10, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link

@sdodson: This pull request references Bugzilla bug 1926262, which is invalid:

  • expected dependent Bugzilla bug 1925740 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 10, 2021
@sdodson
Copy link
Member

sdodson commented Feb 10, 2021

/lgtm
/approve
Upstream bug is ON_QA and this is a test only change.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2021
@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6e846d7 into openshift:release-4.6 Feb 10, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1926262 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1926262: Prevent GCP e2e tests from triggering a rate limit on the listZone API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants