New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.6] Bug 1926262: Prevent GCP e2e tests from triggering a rate limit on the listZone API #556
Conversation
Instead of allowing the cloud provider to guess at the zones that should be applied for a cluster under test, allow the explicit list of zones to consider to be passed as a new test context flag -gce-zones. Only the GCE test cloud provider recognizes this value because only the GCE test cloud provider makes assumptions about zones for verifying values, and the default assumptions for GKE do not always match non-GKE providers.
A number of e2e tests are useful to run after the system has been disrupted or is in the progress of being disrupted, but the current suite and test logic blocks progress waiting for all nodes to be healthy. By passing -1 to --minStartupPods or --allowed-not-ready-nodes flags the caller can bypass wait logic before and after test suites that would prevent running e2e during disruption. This allows use of parts of the e2e suite during cluster duress to verify that controllers or components still function.
@openshift-cherrypick-robot: the contents of this pull request could be automatically validated. The following commits are valid:
|
@openshift-cherrypick-robot: Bugzilla bug 1920221 has been cloned as Bugzilla bug 1926262. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1926262, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/bugzilla refresh |
@sdodson: This pull request references Bugzilla bug 1926262, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: openshift-cherrypick-robot, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1926262 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #552
/assign smarterclayton