Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1933624: 4.6: UPSTREAM: 96751: Lower the frequency of volume plugin deprecation warning #596

Merged
merged 1 commit into from Mar 21, 2021
Merged

Bug 1933624: 4.6: UPSTREAM: 96751: Lower the frequency of volume plugin deprecation warning #596

merged 1 commit into from Mar 21, 2021

Conversation

jsafrane
Copy link

@jsafrane jsafrane commented Mar 1, 2021

The warning is always logged (klog.Warningf), so make sure it's logged only once per process. We've seen clusters where the deprecation warning was about 20% of total logs.

cc @openshift/storage

@jsafrane
UPSTREAM: 96751: Lower the frequency of volume plugin deprecation war…
97cddd6 
…ning

The warning is always logged (klog.Warningf), so make sure it's logged only
once per process. We've seen clusters where the deprecation warning was
about 20% of total logs.
@openshift-ci-robot
Copy link

@jsafrane: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

1924942: 4.6: UPSTREAM: 96751: Lower the frequency of volume plugin deprecation warning

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Mar 1, 2021
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could be automatically validated.

The following commits are valid:

@jsafrane jsafrane changed the title 1924942: 4.6: UPSTREAM: 96751: Lower the frequency of volume plugin deprecation warning Bug 1924942: 4.6: UPSTREAM: 96751: Lower the frequency of volume plugin deprecation warning Mar 1, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 1, 2021
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1924942, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "---" instead
  • expected Bugzilla bug 1924942 to depend on a bug targeting a release in 4.7.0, 4.7.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1924942: 4.6: UPSTREAM: 96751: Lower the frequency of volume plugin deprecation warning

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane jsafrane changed the title Bug 1924942: 4.6: UPSTREAM: 96751: Lower the frequency of volume plugin deprecation warning Bug 1933624: 4.6: UPSTREAM: 96751: Lower the frequency of volume plugin deprecation warning Mar 1, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 1, 2021
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1933624, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1895329 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1895329 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

In response to this:

Bug 1933624: 4.6: UPSTREAM: 96751: Lower the frequency of volume plugin deprecation warning

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Author

jsafrane commented Mar 1, 2021

/test e2e-openstack

@openshift-ci-robot
Copy link

@jsafrane: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test configmap-scale
  • /test e2e-agnostic-cmd
  • /test e2e-agnostic-upgrade
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-azure
  • /test e2e-gcp
  • /test e2e-vsphere
  • /test images
  • /test integration
  • /test k8s-e2e-conformance-aws
  • /test k8s-e2e-gcp
  • /test k8s-e2e-gcp-serial
  • /test unit
  • /test verify
  • /test verify-commits

Use /test all to run the following jobs:

  • pull-ci-openshift-kubernetes-release-4.6-e2e-agnostic-cmd
  • pull-ci-openshift-kubernetes-release-4.6-e2e-agnostic-upgrade
  • pull-ci-openshift-kubernetes-release-4.6-e2e-aws
  • pull-ci-openshift-kubernetes-release-4.6-e2e-aws-csi
  • pull-ci-openshift-kubernetes-release-4.6-e2e-aws-jenkins
  • pull-ci-openshift-kubernetes-release-4.6-e2e-aws-ovn
  • pull-ci-openshift-kubernetes-release-4.6-e2e-aws-serial
  • pull-ci-openshift-kubernetes-release-4.6-e2e-azure
  • pull-ci-openshift-kubernetes-release-4.6-e2e-gcp
  • pull-ci-openshift-kubernetes-release-4.6-images
  • pull-ci-openshift-kubernetes-release-4.6-integration
  • pull-ci-openshift-kubernetes-release-4.6-k8s-e2e-conformance-aws
  • pull-ci-openshift-kubernetes-release-4.6-k8s-e2e-gcp
  • pull-ci-openshift-kubernetes-release-4.6-k8s-e2e-gcp-serial
  • pull-ci-openshift-kubernetes-release-4.6-unit
  • pull-ci-openshift-kubernetes-release-4.6-verify
  • pull-ci-openshift-kubernetes-release-4.6-verify-commits

In response to this:

/test e2e-openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Author

jsafrane commented Mar 1, 2021

/retest

@bertinatto
Copy link
Member

/test e2e-agnostic-cmd

 Failing tests:
[sig-cli][Feature:LegacyCommandTests][Disruptive][Serial] test-cmd: test/cmd/annotations.sh
[sig-cli][Feature:LegacyCommandTests][Disruptive][Serial] test-cmd: test/cmd/framework-test.sh
[sig-cli][Feature:LegacyCommandTests][Disruptive][Serial] test-cmd: test/cmd/help.sh
[sig-cli][Feature:LegacyCommandTests][Disruptive][Serial] test-cmd: test/cmd/images.sh
[sig-cli][Feature:LegacyCommandTests][Disruptive][Serial] test-cmd: test/cmd/projects.sh
[sig-cli][Feature:LegacyCommandTests][Disruptive][Serial] test-cmd: test/cmd/set-image.sh
[sig-cli][Feature:LegacyCommandTests][Disruptive][Serial] test-cmd: test/cmd/set-liveness-probe.sh

@huffmanca
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2021
soltysh
soltysh approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, jsafrane, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021
@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 17, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 263ee0d into openshift:release-4.6 Mar 21, 2021
@openshift-ci-robot
Copy link

@jsafrane: All pull requests linked via external trackers have merged:

Bugzilla bug 1933624 has been moved to the MODIFIED state.

In response to this:

Bug 1933624: 4.6: UPSTREAM: 96751: Lower the frequency of volume plugin deprecation warning

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@huffmanca huffmanca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jsafrane @openshift-ci-robot @bertinatto @huffmanca @openshift-bot @soltysh @ecordell @openshift-merge-robot