Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump IPv6DualStack to beta (early merge from 1.21) #618

Closed
wants to merge 2 commits into from

Conversation

danwinship
Copy link

Pull in the IPv6DualStack alpha->beta migration now, so we can test dual stack in master without needing to override feature gates.

I skimmed for other post-1.20 dual-stack related commits and found:

  • improved e2e testing
  • ipvs fixes
  • cloud/Azure fixes
  • fixes to error handling when the user creates invalid dual-stack services
  • fixes for single-stack clusters where IPv6 is disabled in the kernel

none of which seems immediately necessary (though we may end up merging a few more bits before the eventual 1.21 rebase...)

cc @aojea

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Mar 15, 2021
@openshift-ci-robot
Copy link

@danwinship: the contents of this pull request could be automatically validated.

The following commits are valid:

@aojea
Copy link

aojea commented Mar 15, 2021

/retest

2 similar comments
@danwinship
Copy link
Author

/retest

@aojea
Copy link

aojea commented Mar 15, 2021

/retest

@aojea
Copy link

aojea commented Mar 15, 2021

/test e2e-gcp-upgrade
this can be a legit failure 👀

@danwinship
Copy link
Author

e2e-gcp-upgrade is failing for everyone since Thursday

@aojea
Copy link

aojea commented Mar 16, 2021

/retest

@aojea
Copy link

aojea commented Mar 16, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea, danwinship
To complete the pull request process, please assign soltysh after the PR has been reviewed.
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea
Copy link

aojea commented Mar 17, 2021

/retest

2 similar comments
@aojea
Copy link

aojea commented Mar 17, 2021

/retest

@aojea
Copy link

aojea commented Mar 18, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Mar 24, 2021

@danwinship: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade c16c22e link /test e2e-gcp-upgrade
ci/prow/e2e-aws-downgrade c16c22e link /test e2e-aws-downgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship
Copy link
Author

/assign @soltysh

this is just an early merge from 1.21 to simplify our 4.8 dual-stack testing

@soltysh
Copy link
Member

soltysh commented Mar 25, 2021

Spoke with @danwinship on slack, this can wait roughly a week, by then we should be ready with #624.
/close

@openshift-ci-robot
Copy link

@soltysh: Closed this PR.

In response to this:

Spoke with @danwinship on slack, this can wait roughly a week, by then we should be ready with #624.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants