[WIP] Rebase 1.21.0 beta.1 #624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prioritizing nodes based on volume capacity
- Change the feature gate from alpha to beta and enable it by default - Update a few of the unit tests due to feature gate being enabled by default - Small refactor in `nodeshutdown_manager` which adds `featureEnabled` function (which checks that feature gate and that `kubeletConfig.ShutdownGracePeriod > 0`). - Use `featureEnabled()` to exit early from shutdown manager in the case that the feature is disabled - Update kubelet config defaulting to be explicit that `ShutdownGracePeriod` and `ShutdownGracePeriodCriticalPods` default to zero and update the godoc comments. - Update defaults and add featureGate tag in api config godoc. With this feature now in beta and the feature gate enabled by default, to enable graceful shutdown all that will be required is to configure `ShutdownGracePeriod` and `ShutdownGracePeriodCriticalPods` in the kubelet config. If not configured, they will be defaulted to zero, and graceful shutdown will effectively be disabled.
…down Promote kubelet graceful node shutdown to beta
now that bazel is removed, this automates cleanup.
…me-windows Get Windows Process time correctly
This PR also looses the check to allow zero since the API doc has explained that value zero indicates no waiting. Signed-off-by: Dave Chen <dave.chen@arm.com>
…meContainerLog Optimization log: add containerName to log
Add request value verification for hugepage
Agnhost: make it possible to pass the addresses to listen on for udp
Add tool to check use of unstructured logs
Signed-off-by: yahaa <1477765176@qq.com>
Use protobuf for kubectl top
Switch to batch/v1 in cronjob's e2es
…ge_impl DaemonSet controller respects MaxSurge during update
Refactor format.Pods to return a slice of ObjRef for structured logging. Ref: kubernetes#99029 (comment) Signed-off-by: Qi Wang <qiwan@redhat.com>
…mestamp Logarithmic timestamp comparison for downscaling
…api-hugepages e2e testing for hugepages downward api
Make all health checks probing consistent
remove listx from OWNERS
…accept-KubeSchedulerProfile Make runtime.NewFramework accept KubeSchedulerProfile
This comment has been minimized.
This comment has been minimized.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This comment has been minimized.
This comment has been minimized.
When PodAffinityNamespaceSelector goes to beta or GA this might affect how our ClusterResourceQuota might work
soltysh
force-pushed
the
rebase-1.21.0-beta.1
branch
from
7e4b323
to
d9d6f0e
Compare
This comment has been minimized.
This comment has been minimized.
|
/test unit |
|
/retest |
|
/test e2e-gcp |
|
/retest |
|
@soltysh: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
aravindhp
added a commit
to aravindhp/windows-machine-config-operator
that referenced
this pull request
Mar 23, 2021
aravindhp
added a commit
to aravindhp/windows-machine-config-operator
that referenced
this pull request
Mar 23, 2021
|
@soltysh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cc |
|
Replaced with #641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking sheet https://docs.google.com/spreadsheets/d/10KYptJkDB1z8_RYCQVBYDjdTlRfyoXILMa0Fg8tnNlY