Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1958371: UPSTREAM: 98424: register all pending pod deletions and check for kill #779

Merged
merged 6 commits into from Jun 3, 2021
Merged

Bug 1958371: UPSTREAM: 98424: register all pending pod deletions and check for kill #779

merged 6 commits into from Jun 3, 2021

Conversation

ehashman
Copy link

@ehashman ehashman commented Jun 1, 2021

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Jun 1, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jun 1, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2021

@ehashman: This pull request references Bugzilla bug 1958371, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "4.8.0" instead
  • expected Bugzilla bug 1958371 to depend on a bug targeting a release in 4.7.0, 4.7.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1958371: UPSTREAM: 98424: register all pending pod deletions and check for kill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 1, 2021
@openshift-ci-robot
Copy link

@ehashman: the contents of this pull request could be automatically validated.

The following commits are valid:

@ehashman
Copy link
Author

ehashman commented Jun 1, 2021

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2021

@ehashman: This pull request references Bugzilla bug 1958371, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1915085 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1915085 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 1, 2021
@openshift-ci openshift-ci bot requested review from mrunalp and rphillips June 1, 2021 19:28
@openshift-ci-robot
Copy link

@ehashman: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. and removed backports/validated-commits Indicates that all commits come to merged upstream PRs. labels Jun 1, 2021
@ehashman
Copy link
Author

ehashman commented Jun 1, 2021

Unit test flake on issue fixed by #767, I will backport...

@ehashman
Copy link
Author

ehashman commented Jun 2, 2021

/skip
/test unit

@ehashman
Copy link
Author

ehashman commented Jun 2, 2021

Unit test flake is kubernetes#96048 ... guess I'll backport that too

@rphillips @ehashman
UPSTREAM: 96048: kubelet/cm/devicemanager: fix race in stub
7cd6678 
There is a race when the server is coming up and the subsequent dial on
the socket. Fix the race with a PollImmediate retry.
@openshift-ci-robot
Copy link

@ehashman: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

@gjkim42 @ehashman
UPSTREAM: 98956: kubelet: Fix race when KillPod followed by IsPodPend…
51ae270 
…ingTermination

Ensures the pod to be pending termination or be killed, after
(*podKillerWithChannel).KillPod has been returned, by limiting
one request per pod in (*podKillerWithChannel).KillPod.
@gjkim42 @ehashman
UPSTREAM: 98956: kubelet: Simulate KillPod in TestSyncPodsDeletesWhen…
1309622 
…SourcesAreReadyPerQOS
@openshift-ci-robot
Copy link

@ehashman: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

@ehashman
Copy link
Author

ehashman commented Jun 3, 2021

One more flake fix for this

@ehashman
Copy link
Author

ehashman commented Jun 3, 2021

/test e2e-gcp

@rphillips
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, mrunalp, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2021
@mrunalp mrunalp removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 3, 2021
@derekwaynecarr derekwaynecarr added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 3, 2021
@derekwaynecarr
Copy link
Member

[patch-manager] 🚀 Approved for z-stream by score: 1.50

approved

@openshift-merge-robot openshift-merge-robot merged commit c3e2e69 into openshift:release-4.6 Jun 3, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2021

@ehashman: All pull requests linked via external trackers have merged:

Bugzilla bug 1958371 has been moved to the MODIFIED state.

In response to this:

Bug 1958371: UPSTREAM: 98424: register all pending pod deletions and check for kill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@rphillips rphillips Awaiting requested review from rphillips

Assignees

@rphillips rphillips

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ehashman @openshift-ci-robot @rphillips @derekwaynecarr @mrunalp @openshift-merge-robot @gjkim42