produce events for readyz going true #807
Conversation
…phase and graceful termination phase
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@deads2k: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
openshift-ci
bot
added
the
approved
|
/test e2e-aws-upgrade |
|
readyz events are working, associated by master /retest /test e2e-aws-upgrade |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
sttts
removed
the
backports/unvalidated-commits
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold integration is borked somehow |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@deads2k: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
| @@ -588,7 +588,7 @@ func eventReference() (*corev1.ObjectReference, error) { | |||
| } | |||
| if len(ns) == 0 { | |||
| pod = "" | |||
| ns = "kube-system" | |||
| ns = "openshift-kube-apiserver" | |||
There was a problem hiding this comment.
@s-urbaniak @sttts using kube-system through off an event integration test. Also, we know that our kube-apiserver is never in kube-system. Oddly, this entire method appears to be carried (stefan I think?), but it's not in a patch file.
There was a problem hiding this comment.
👍 for changing this.
@mfojtik is this your code?
|
@deads2k: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
/hold cancel got it worked out. |
openshift-ci
bot
removed
the
do-not-merge/hold
deads2k
removed
the
backports/unvalidated-commits
|
/lgtm Tests are red. |
|
failures appear unrelated atm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
trying to debug when our kube-apiservers are going readyz=true