-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flake when SCCs are not associated yet #26225
Flake when SCCs are not associated yet #26225
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ravisantoshgudimetla The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/synthetictests/networking.go
Outdated
@@ -42,6 +42,10 @@ func testPodSandboxCreation(events monitorapi.Intervals) []*ginkgo.JUnitTestCase | |||
flakes = append(flakes, fmt.Sprintf("%v - multus is unable to get pods due to LB disruption https://bugzilla.redhat.com/show_bug.cgi?id=1927264 - %v", event.Locator, event.Message)) | |||
continue | |||
} | |||
if strings.Contains(event.Message, "Multus") && strings.Contains(event.Message, "error getting pod") && strings.Contains(event.Message, "is forbidden: User \"system:serviceaccount:openshift-multus:multus\"") { | |||
flakes = append(flakes, fmt.Sprintf("%v - multus is unable to get pods due to not getting required SCCs https://bugzilla.redhat.com/show_bug.cgi?id=1961204 - %v", event.Locator, event.Message)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a GET request doesn't ever use SCC
the fix and bug dont' appear related /hold |
https://bugzilla.redhat.com/show_bug.cgi?id=1961204 was punted to 4.9 release, however occasionally we see multus not getting SCCs in time causing auth issues. This commit causes the test to flake in such scenarios instead of failing. This is a temporary measure to get better signal for 4.8 upgrades. We need to remove this when the associated bug has been fixed
73af412
to
595740d
Compare
one possibility is that there is no ready kube-apiserver. Another possibility is that there is a ready kube-apiserver, but for some reason the LB isn't detecting it. openshift/kubernetes#807 should show the reality of being ready at any given time. I'm not sure how to collect the list of endpoints for a load balancer. Perhaps the SPLAT team knows how to do this? |
@ravisantoshgudimetla: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ravisantoshgudimetla: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=1961204 was punted
to 4.9 release, however occasionally we see multus not
getting SCCs in time causing auth issues. This commit
causes the test to flake in such scenarios instead of
failing. This is a temporary measure to get better
signal for 4.8 upgrades. We need to remove this
when the associated bug has been fixed
cc @vrutkovs @dcbw