UPSTREAM: <carry>: add a way to inject a vulnerable, legacy service-c… #852
Conversation
…a.crt for migration compatibility
openshift-ci-robot
added
the
backports/unvalidated-commits
|
@deads2k: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
openshift-ci
bot
added
the
approved
| } | ||
| useVulnerableBool, err := strconv.ParseBool(useVulnerable) | ||
| if err != nil { | ||
| // caller went crazy, don't use this unless you're careful |
There was a problem hiding this comment.
nit: I'm not able to discern your intent from this comment, maybe restate?
(No action required) Given that ParseBool will return an error if the value is not something that can be converted to a boolean, maybe emit a more explicit failure message (i.e. Value supplied for OPENSHIFT_USE_VULNERABLE_LEGACY_SERVICE_CA_CRT cannot be parsed as a boolean: %v) so that the solution to the error is obvious from the log entry alone?
There was a problem hiding this comment.
(No action required) Given that
ParseBoolwill return an error if the value is not something that can be converted to a boolean, maybe emit a more explicit failure message (i.e.Value supplied for OPENSHIFT_USE_VULNERABLE_LEGACY_SERVICE_CA_CRT cannot be parsed as a boolean: %v) so that the solution to the error is obvious from the log entry alone?
You are correct. I'm hoping to see more refinement in this area in either 4.9 or 4.10. Perhaps by removing the KCM patch entirely. This is ugly, but it will leave a stack line and it means the operator failed. I'd like to leave this as-is without having error in the return path for backporting.
|
/hold for other reviewers |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, marun, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deads2k
removed
backports/unvalidated-commits
|
/cherry-pick release-4.8 |
|
@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@deads2k: new pull request created: #856 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…a.crt for migration compatibility
part 3 of the plan from openshift/service-ca-operator#167