Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1994643: UPSTREAM: <carry>: send Retry-After when not ready with a caller opt in #906

Merged
merged 1 commit into from Aug 28, 2021

Conversation

tkashem
Copy link

@tkashem tkashem commented Aug 25, 2021

No description provided.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 25, 2021
@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci openshift-ci bot requested review from marun and sttts August 25, 2021 20:17
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Aug 25, 2021
@tkashem tkashem changed the title UPSTREAM: <carry>: send Retry-After when not ready with a caller opt in Bug 1994643: UPSTREAM: <carry>: send Retry-After when not ready with a caller opt in Aug 26, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 26, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 26, 2021

@tkashem: This pull request references Bugzilla bug 1994643, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1994643: UPSTREAM: : send Retry-After when not ready with a caller opt in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci-robot
Copy link

@tkashem: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@tkashem
Copy link
Author

tkashem commented Aug 26, 2021

/retest

1 similar comment
@tkashem
Copy link
Author

tkashem commented Aug 26, 2021

/retest

@sttts sttts removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 28, 2021
@sttts
Copy link

sttts commented Aug 28, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2021
@sttts
Copy link

sttts commented Aug 28, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 28, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2021

@sttts: This pull request references Bugzilla bug 1994643, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gangwgr

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link

sttts commented Aug 28, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2021

@tkashem: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-cmd 382cb50 link /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 726124c into openshift:master Aug 28, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 28, 2021

@tkashem: All pull requests linked via external trackers have merged:

Bugzilla bug 1994643 has been moved to the MODIFIED state.

In response to this:

Bug 1994643: UPSTREAM: : send Retry-After when not ready with a caller opt in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants