Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #19

Merged
merged 8 commits into from Aug 26, 2019
Merged

Rebase openshift/kuryr-kubernetes from https://opendev.org/openstack/kuryr-kubernetes #19

merged 8 commits into from Aug 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2019

No description provided.

Nayan Deshmukh and others added 8 commits August 12, 2019 10:33
Print uid with log to facilitate log tracking
b3d808f 
Change-Id: I371ebae572042688934f51524df888be1a468bf4
Signed-off-by: Nayan Deshmukh <n.deshmukh@samsung.com>
cni: print different error logs for timeout errors
a446f05 
Print different error logs for timeout of vif appearing in
registry and vif activation timeout. Before we were printing
same error log for both cases.

Change-Id: I3fdf5b751ba64d26df344cb4f4a5359f59e652a6
Signed-off-by: Nayan Deshmukh <n.deshmukh@samsung.com>
@openstack-gerrit
Merge "Print uid with log to facilitate log tracking"
98fc2c2
@openstack-gerrit
Merge "cni: print different error logs for timeout errors"
5c2f302
@luis5tb
Ensure readiness probe waits for sync pools upon controller restart
492036e 
This patch ensures the readiness probe is still waiting for the
pools to be sync after a kuryr-controller pod restart. In addition
it also changes the order of syncing pools and cleanup leftovers
ports.

Change-Id: I6aa30ee17fa172d88edd54cd7d1f47212b087d1c
@dulek
Put correct API group for Routes RBAC permissions
a6feca6 
In order to support OpenShift Routes, kuryr-controller needs access to
routes API group. This commit fixes it putting "route.openshift.io" as
the API group in question instead of obsolete oapi.

Change-Id: I53aa7dac36bbfa362fad2f4a943a0a9b549f600c
@openstack-gerrit
Merge "Put correct API group for Routes RBAC permissions"
295f8f1
@dulek
Merge https://opendev.org/openstack/kuryr-kubernetes:master into master
40ffebe
@openshift-ci-robot
Copy link

Hi @kuryr-bot. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 23, 2019
@dulek
Copy link
Contributor

dulek commented Aug 23, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2019
@luis5tb
Copy link
Contributor

luis5tb commented Aug 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuryr-bot, luis5tb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7dcddcd into openshift:master Aug 26, 2019
@ghost ghost deleted the rebase-2019-08-23 branch August 29, 2019 12:40
MaysaMacedo pushed a commit to MaysaMacedo/kuryr-kubernetes-1 that referenced this pull request Jul 1, 2021
@openshift-merge-robot
Merge pull request openshift#19 from squeed/openshift-sdn
9167b75 
Openshift-sdn support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulek dulek Awaiting requested review from dulek

@yboaron yboaron Awaiting requested review from yboaron

Assignees

@luis5tb luis5tb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-ci-robot @dulek @luis5tb @openshift-merge-robot