[release-4.6] Bug 1906741: Skip unscheduled pods when deleting NPs #428

openshift-cherrypick-robot · 2020-12-11T10:47:58Z

This is an automated cherry-pick of #426

/assign dulek

It may happen that there's an unscheduled pod matching a policy when NP is getting deleted. In that case we'll get a traceback as pod has no nodeName set. This commit fixes that by making sure we skip unscheduled pods when detaching SGs from ports on NP deletion. Change-Id: I5b712ba97e030192d1d24cce2585724a78408e23 Closes-Bug: 1904040

openshift-ci-robot · 2020-12-11T10:48:10Z

@openshift-cherrypick-robot: Bugzilla bug 1904973 has been cloned as Bugzilla bug 1906741. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1906741: Skip unscheduled pods when deleting NPs

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dulek · 2020-12-11T10:48:24Z

/lgtm
/approve

openshift-ci-robot · 2020-12-11T10:48:32Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-12T01:01:07Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-12T01:01:11Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-13T01:00:55Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-13T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-14T01:00:55Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-14T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-15T01:01:06Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-15T01:01:09Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-16T01:00:27Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-16T01:00:31Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-17T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-17T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-18T01:00:58Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-18T01:01:02Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-19T01:00:30Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-19T01:00:34Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-20T01:00:34Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-20T01:00:37Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-21T01:02:24Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-21T01:02:28Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-22T01:00:31Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-12-22T01:00:40Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dulek · 2020-12-22T09:14:43Z

/hold

I'll need to add another patch to this PR once it merges on 4.7.

openshift-bot · 2021-01-01T00:02:18Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci-robot · 2021-01-01T00:02:21Z

@openshift-bot: This pull request references Bugzilla bug 1906741, which is invalid:

expected dependent Bugzilla bug 1904973 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This is follow up to dce5939, as apparently same problem can happen on NP creation. This patch makes sure we skip unscheduled pods there too. Change-Id: I20bab73f3adcc12cc103ba82d2f2dfda9841efde Closes-Bug: 1904040

dulek · 2021-01-07T13:22:16Z

/hold cancel

This is now updated with an additional commit due to failed verification on 4.7.

luis5tb · 2021-01-12T07:43:05Z

/lgtm

openshift-ci-robot · 2021-01-12T07:43:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, luis5tb, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dulek,luis5tb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dulek · 2021-01-12T08:29:05Z

/bugzilla refresh

openshift-ci-robot · 2021-01-12T08:29:10Z

@dulek: This pull request references Bugzilla bug 1906741, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1904973 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1904973 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-27T21:08:30Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/kuryr-kubernetes#428

Bugzilla bug 1906741 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned dulek Dec 11, 2020

openshift-cherrypick-robot mentioned this pull request Dec 11, 2020

Bug 1904973: Skip unscheduled pods when deleting NPs #426

Merged

openshift-ci-robot requested review from dulek and gryf December 11, 2020 10:48

openshift-ci-robot changed the title ~~[release-4.6] Bug 1904973: Skip unscheduled pods when deleting NPs~~ [release-4.6] Bug 1906741: Skip unscheduled pods when deleting NPs Dec 11, 2020

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 11, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 11, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. labels Dec 12, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2020

Skip unscheduled pods when handling NP creation

10fc3a2

This is follow up to dce5939, as apparently same problem can happen on NP creation. This patch makes sure we skip unscheduled pods there too. Change-Id: I20bab73f3adcc12cc103ba82d2f2dfda9841efde Closes-Bug: 1904040

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2021

openshift-ci-robot assigned luis5tb Jan 12, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 12, 2021

jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 27, 2021

openshift-merge-robot merged commit f94ce69 into openshift:release-4.6 Jan 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.6] Bug 1906741: Skip unscheduled pods when deleting NPs #428

[release-4.6] Bug 1906741: Skip unscheduled pods when deleting NPs #428

openshift-cherrypick-robot commented Dec 11, 2020

openshift-ci-robot commented Dec 11, 2020

dulek commented Dec 11, 2020

openshift-ci-robot commented Dec 11, 2020

openshift-bot commented Dec 12, 2020

openshift-ci-robot commented Dec 12, 2020

openshift-bot commented Dec 13, 2020

openshift-ci-robot commented Dec 13, 2020

openshift-bot commented Dec 14, 2020

openshift-ci-robot commented Dec 14, 2020

openshift-bot commented Dec 15, 2020

openshift-ci-robot commented Dec 15, 2020

openshift-bot commented Dec 16, 2020

openshift-ci-robot commented Dec 16, 2020

openshift-bot commented Dec 17, 2020

openshift-ci-robot commented Dec 17, 2020

openshift-bot commented Dec 18, 2020

openshift-ci-robot commented Dec 18, 2020

openshift-bot commented Dec 19, 2020

openshift-ci-robot commented Dec 19, 2020

openshift-bot commented Dec 20, 2020

openshift-ci-robot commented Dec 20, 2020

openshift-bot commented Dec 21, 2020

openshift-ci-robot commented Dec 21, 2020

openshift-bot commented Dec 22, 2020

openshift-ci-robot commented Dec 22, 2020

dulek commented Dec 22, 2020

openshift-bot commented Jan 1, 2021

openshift-ci-robot commented Jan 1, 2021

dulek commented Jan 7, 2021

luis5tb commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

dulek commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 27, 2021

[release-4.6] Bug 1906741: Skip unscheduled pods when deleting NPs #428

[release-4.6] Bug 1906741: Skip unscheduled pods when deleting NPs #428

Conversation

openshift-cherrypick-robot commented Dec 11, 2020

openshift-ci-robot commented Dec 11, 2020

dulek commented Dec 11, 2020

openshift-ci-robot commented Dec 11, 2020

openshift-bot commented Dec 12, 2020

openshift-ci-robot commented Dec 12, 2020

openshift-bot commented Dec 13, 2020

openshift-ci-robot commented Dec 13, 2020

openshift-bot commented Dec 14, 2020

openshift-ci-robot commented Dec 14, 2020

openshift-bot commented Dec 15, 2020

openshift-ci-robot commented Dec 15, 2020

openshift-bot commented Dec 16, 2020

openshift-ci-robot commented Dec 16, 2020

openshift-bot commented Dec 17, 2020

openshift-ci-robot commented Dec 17, 2020

openshift-bot commented Dec 18, 2020

openshift-ci-robot commented Dec 18, 2020

openshift-bot commented Dec 19, 2020

openshift-ci-robot commented Dec 19, 2020

openshift-bot commented Dec 20, 2020

openshift-ci-robot commented Dec 20, 2020

openshift-bot commented Dec 21, 2020

openshift-ci-robot commented Dec 21, 2020

openshift-bot commented Dec 22, 2020

openshift-ci-robot commented Dec 22, 2020

dulek commented Dec 22, 2020

openshift-bot commented Jan 1, 2021

openshift-ci-robot commented Jan 1, 2021

dulek commented Jan 7, 2021

luis5tb commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

dulek commented Jan 12, 2021

openshift-ci-robot commented Jan 12, 2021

openshift-ci-robot commented Jan 27, 2021