Bug 2015154: Support for ports and primarySubnet fields in machine #583
Conversation
For now, by default, pod network was taken from OpenShift Machine spec, by looking for "networks" field and get the first item out of it to figure out right subnet. Currently there is another field, where networks can be defined - under "ports" field, where subnet for fixed IPs can be found. Additionally, to avoid confusion, there is another field, which defines primary subnet for the pods - "primarySubnet". Implementation has been adapted to reflect that change: 1. primarySubnet will be examined, to get the subnet id 2. if primarySubnet does not exists, networks field will be examined 3. if there is no networks field (or it doesn't contain subnets), ports field will be examined for subnet id Change-Id: I35b6f2e6288cbe3fd80b74a5da03639d7bd0a765
We're moving this because we discovered that Octavia will not always raise Conflict if you create an LB with the same IP. If no VIP port got created for an LB, then Octavia will not have any issue with creating another LB with the same IP. Closes-Bug: 1947809 Change-Id: I26b911b30403c7ea5a35706b2fc80af499e91330
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @kuryr-bot. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label ok-to-test |
|
@MaysaMacedo: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kuryr-bot, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retitle Bug 2015154: Support for ports and primarySubnet fields in machine |
openshift-ci
bot
changed the title
|
@kuryr-bot: Bugzilla bug 2015154 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.