Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] Bug 2055661: Update KLB .spec.provider when required #637

Merged
merged 1 commit into from
Apr 8, 2022
Merged

[release-4.10] Bug 2055661: Update KLB .spec.provider when required #637

merged 1 commit into from
Apr 8, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #636

/assign dulek

@dulek
Update KLB .spec.provider when required
23d80de 
During the refactoring to allow proper Events creation for Services,
we've lost ability to update KLBs .spec.provider when configuration is
changed to use another provider. This commit fixes it by making sure
.spec.provider mismatch with the configured provider triggers the .spec
update.

Change-Id: Ic93a105b4a67b8dff15bf0e80b13f4743ffce7ff
Closes-Bug: 1960311
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 17, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2022

@openshift-cherrypick-robot: Bugzilla bug 2051423 has been cloned as Bugzilla bug 2055661. Retitling PR to link against new bug.
/retitle [release-4.10] Bug 2055661: Update KLB .spec.provider when required

In response to this:

[release-4.10] Bug 2051423: Update KLB .spec.provider when required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.10] Bug 2051423: Update KLB .spec.provider when required [release-4.10] Bug 2055661: Update KLB .spec.provider when required Feb 17, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2055661, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2051423 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2051423 targets the "4.11.0" release, which is one of the valid target releases: 4.11.0
  • bug has dependents

Requesting review from QA contact:
/cc @eurijon

In response to this:

[release-4.10] Bug 2055661: Update KLB .spec.provider when required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link
Contributor

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaysaMacedo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dulek
Copy link
Contributor

dulek commented Apr 7, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 7, 2022
@eurijon
Copy link

eurijon commented Apr 8, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2c0e042 into openshift:release-4.10 Apr 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2055661 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2055661: Update KLB .spec.provider when required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurijon eurijon Awaiting requested review from eurijon

@luis5tb luis5tb Awaiting requested review from luis5tb

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

Assignees

@dulek dulek

@MaysaMacedo MaysaMacedo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @MaysaMacedo @openshift-bot @dulek @eurijon @openshift-merge-robot