WIP: Added the callback shouldRevisionInstall to provide additional c…

…onditions for installation

Signed-off-by: jubittajohn <jujohn@redhat.com>

pkg/operator/staticpod/controller/installer/installer_controller.go

@@ -98,6 +98,8 @@ type InstallerController struct {
 	clock            clock.Clock
 	installerBackOff func(count int) time.Duration
 	fallbackBackOff  func(count int) time.Duration
+
+	shouldRevisionInstall func() (bool, error)
 }
 
 // InstallerPodMutationFunc is a function that has a chance at changing the installer pod before it is created
@@ -128,6 +130,11 @@ func (c *InstallerController) WithStartupMonitorSupport(startupMonitorEnabled fu
 	return c
 }
 
+func (c *InstallerController) WithShouldRevisionInstall(shouldRevisionInstall func() (bool, error)) *InstallerController {
+	c.shouldRevisionInstall = shouldRevisionInstall
+	return c
+}
+
 // staticPodState is the status of a static pod that has been installed to a node.
 type staticPodState int
 
@@ -447,6 +454,16 @@ func (c *InstallerController) manageInstallationPods(ctx context.Context, operat
 		return true, requeueAfter, nil
 	}
 
+	// Check if revision should be installed based on if the quorum is about to be violated
+	if c.shouldRevisionInstall != nil {
+		quorumSafe, err := c.shouldRevisionInstall()
+		if !quorumSafe {
+			return true, 30 * time.Second, err
+		} else {
+			return false, 0, nil
+		}
+	}
+
 	for l := 0; l < len(operatorStatus.NodeStatuses); l++ {
 		i := (startNode + l) % len(operatorStatus.NodeStatuses)
 

pkg/operator/staticpod/controllers.go

@@ -75,6 +75,9 @@ type staticPodOperatorControllerBuilder struct {
 	readyzEndpoint                string
 	pdbUnhealthyPodEvictionPolicy *v1.UnhealthyPodEvictionPolicyType
 	guardCreateConditionalFunc    func() (bool, bool, error)
+
+	// should revision install information
+	shouldRevisionInstall func() (bool, error)
 }
 
 func NewBuilder(
@@ -114,6 +117,7 @@ type Builder interface {
 	// This can help to drain/maintain a node and recover without a manual intervention when multiple instances of nodes or pods are misbehaving.
 	// Use this with caution, as this option can disrupt perspective pods that have not yet had a chance to become healthy.
 	WithPodDisruptionBudgetGuard(operatorNamespace, operatorName, readyzPort, readyzEndpoint string, pdbUnhealthyPodEvictionPolicy *v1.UnhealthyPodEvictionPolicyType, createConditionalFunc func() (bool, bool, error)) Builder
+	WithShouldRevisionInstall(quorumSafe func() (bool, error)) Builder
 	ToControllers() (manager.ControllerManager, error)
 }
 
@@ -196,6 +200,11 @@ func (b *staticPodOperatorControllerBuilder) WithPodDisruptionBudgetGuard(operat
 	return b
 }
 
+func (b *staticPodOperatorControllerBuilder) WithShouldRevisionInstall(quorumSafe func() (bool, error)) Builder {
+	b.shouldRevisionInstall = quorumSafe
+	return b
+}
+
 func (b *staticPodOperatorControllerBuilder) ToControllers() (manager.ControllerManager, error) {
 	manager := manager.NewControllerManager()
 
@@ -257,6 +266,8 @@ func (b *staticPodOperatorControllerBuilder) ToControllers() (manager.Controller
 			b.installerPodMutationFunc,
 		).WithMinReadyDuration(
 			b.minReadyDuration,
+		).WithShouldRevisionInstall(
+			b.shouldRevisionInstall,
 		), 1)
 
 		manager.WithController(installerstate.NewInstallerStateController(