Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIECLOUD-586] - Update RHPAM and RHDM templates and imagestreams on … #333

Closed
wants to merge 1 commit into from

Conversation

spolti
Copy link
Contributor

@spolti spolti commented Aug 1, 2022

…OpenShift Service Catalog for 7.13.0 release

Signed-off-by: spolti fspolti@redhat.com

…OpenShift Service Catalog for 7.13.0 release

Signed-off-by: spolti <fspolti@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: spolti
Once this PR has been reviewed and has the lgtm label, please assign gabemontero for approval by writing /assign @gabemontero in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

@spolti: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fbm3307
Copy link
Contributor

fbm3307 commented Aug 2, 2022

Hi @spolti I would like to suggest that instead of creating templates in openshift/library, you can create helm charts for the same (See here https://github.com/openshift-helm-charts/charts )
It is easier to create helm charts and also the helm charts would be available across ocp version 4.8 to latest 4.11. In this you will not have to worry about backporting or waiting for the release, also no worries on checking if compatible with the new release and all those dependencies.

@spolti
Copy link
Contributor Author

spolti commented Aug 2, 2022

Hi @fbm3307 we do not maintain these templates anymore, we still have it because we have a few customers that are still using it on ocp 3.11 and have no plans to create helm charts for it, but, this repo is for ocp 4.x, right? If so I'll close it. :)

@fbm3307
Copy link
Contributor

fbm3307 commented Aug 2, 2022

Hi @spolti yes, and can these be removed if they are not supported in 4.x ? if yes can you raise a PR for the same?

@spolti
Copy link
Contributor Author

spolti commented Aug 3, 2022

@fbm3307 thanks for confirming, about the previous versions, do we really need to remove it or do you mean just remove it from the official.yaml file?

@spolti spolti closed this Aug 3, 2022
@spolti spolti deleted the KIECLOUD-586 branch August 3, 2022 13:12
@fbm3307
Copy link
Contributor

fbm3307 commented Aug 9, 2022

@spolti we need to remove all of it from jsons.. and also remove it from library.( whichever are no longer supported)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants