Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHPAM-4503] Remove RHPAM templates from OCP 4 catalog #336

Merged
merged 4 commits into from Oct 13, 2022
Merged

[RHPAM-4503] Remove RHPAM templates from OCP 4 catalog #336

merged 4 commits into from Oct 13, 2022

Conversation

davidesalerno
Copy link
Contributor

@davidesalerno davidesalerno commented Oct 4, 2022 •
edited

Signed-off-by: Davide Salerno dsalerno@redhat.com

See RHPAM-4503

Change requested by @fbm3307 here #333 (comment)

I checked that everything is working executing these steps:

  1. make build
  2. make import
  3. make verify (finished successfully for both official and community library)

@davidesalerno
[RHPAM-4503] Remove RHPAM templates from OCP 4 catalog
7fc0dc1 
Signed-off-by: Davide Salerno <dsalerno@redhat.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

Hi @davidesalerno. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spolti
Copy link
Contributor

spolti commented Oct 4, 2022

@fbm3307 fyi

spolti
spolti reviewed Oct 4, 2022
View reviewed changes
official.yaml Outdated
@@ -789,49 +764,6 @@ data:
tags:
- online-professional
rhpam:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this entire section.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove the ips_ds_version sections and envs from the beginning of this file.

spolti
spolti suggested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @davidesalerno , just a few comments.

official.yaml Outdated
@@ -789,49 +764,6 @@ data:
tags:
- online-professional
rhpam:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove the ips_ds_version sections and envs from the beginning of this file.

@spolti spolti mentioned this pull request Oct 4, 2022
Closed
@fbm3307
Copy link
Contributor

fbm3307 commented Oct 10, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2022
@fbm3307
Copy link
Contributor

fbm3307 commented Oct 10, 2022 •
edited

@davidesalerno would you please update as per @spolti's comments.?

@davidesalerno
Copy link
Contributor Author

@fbm3307 yes

@davidesalerno
Changes coming from PR code review
331539e 
Signed-off-by: Davide Salerno <dsalerno@redhat.com>
@fbm3307
Copy link
Contributor

fbm3307 commented Oct 10, 2022

/retest

spolti
spolti reviewed Oct 10, 2022
View reviewed changes
official.yaml Outdated Show resolved Hide resolved
spolti
spolti reviewed Oct 10, 2022
View reviewed changes
official.yaml Outdated Show resolved Hide resolved
@davidesalerno
Copy link
Contributor Author

@fbm3307 We also cleaned up the arch path from folders related to rhdm | decisionserver | processerver | rhpam.
Is it that fine?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

@davidesalerno: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dperaza4dustbit
dperaza4dustbit approved these changes Oct 13, 2022
View reviewed changes
Copy link

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidesalerno, dperaza4dustbit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@fbm3307
Copy link
Contributor

fbm3307 commented Oct 13, 2022

@fbm3307 We also cleaned up the arch path from folders related to rhdm | decisionserver | processerver | rhpam. Is it that fine?

@davidesalerno yes it is fine and Thanks for this @spolti appreciate your help on this

@openshift-merge-robot openshift-merge-robot merged commit a717cb0 into openshift:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolti spolti spolti requested changes

@dperaza4dustbit dperaza4dustbit dperaza4dustbit approved these changes

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@dperaza4dustbit dperaza4dustbit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidesalerno @spolti @fbm3307 @dperaza4dustbit @openshift-merge-robot