Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apiVersion for decisionserver templates #335

Conversation

mcarlett
Copy link

@mcarlett mcarlett commented Sep 1, 2022

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mcarlett
Once this PR has been reviewed and has the lgtm label, please assign dperaza4dustbit for approval by writing /assign @dperaza4dustbit in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2022

Hi @mcarlett. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fbm3307
Copy link
Contributor

fbm3307 commented Sep 6, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2022
@mcarlett
Copy link
Author

mcarlett commented Sep 6, 2022

/retest

1 similar comment
@fbm3307
Copy link
Contributor

fbm3307 commented Sep 7, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2022

@mcarlett: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 8714b43 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spolti
Copy link
Contributor

spolti commented Oct 4, 2022

Hi @fbm3307, this PR can be close due #336

@fbm3307
Copy link
Contributor

fbm3307 commented Oct 10, 2022

Hi @fbm3307, this PR can be close due #336

@spolti this doesnt require to be merged..?

@spolti
Copy link
Contributor

spolti commented Oct 10, 2022

No.

@fbm3307
Copy link
Contributor

fbm3307 commented Oct 11, 2022

@mcarlett can you please close this PR..?

@mcarlett mcarlett closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants