Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump-up Prometheus client #490

Merged

Conversation

tisnik
Copy link
Contributor

@tisnik tisnik commented Feb 25, 2024

Description

Bump-up Prometheus client

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

@tisnik
Copy link
Contributor Author

tisnik commented Feb 25, 2024

/retest

@bparees
Copy link
Contributor

bparees commented Feb 25, 2024

you want to wait and use this as a test case for dependabot? or is there an urgency to get this bumped?

/approve

Copy link

openshift-ci bot commented Feb 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2024
@tisnik
Copy link
Contributor Author

tisnik commented Feb 25, 2024

you want to wait and use this as a test case for dependabot? or is there an urgency to get this bumped?

/approve

This issue prometheus/client_python#999 occurs time to time on my machine, so it might occur on clutsers too. IMHO better to update.

@bparees
Copy link
Contributor

bparees commented Feb 25, 2024

ok

/lgtm

still gonna need CI to be fixed :(

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4488f2a and 2 for PR HEAD 831fcff in total

@tisnik
Copy link
Contributor Author

tisnik commented Feb 26, 2024

/retest

Copy link

openshift-ci bot commented Feb 26, 2024

@tisnik: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3d53219 into openshift:main Feb 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants