Enable graceful shutdown for start_{http,wsgi}_server #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antti Rasinen <antti.rasinen@relexsolutions.com>
csmarchbanks
approved these changes
Jan 25, 2024
|
It's quite useful with long(ish) teardown situations and short scrape intervals. The metrics can get pretty skewed and meaningless since there's no new data coming in. Easier just to not respond at all instead of inventing new |
|
Is there going to be a pypi release for this? @csmarchbanks |
|
There will be soon, hopefully in the next week or two, definitely this month. Hoping to batch a couple other changes into the release. |
|
@jwiesler I just released https://github.com/prometheus/client_python/releases/tag/v0.20.0 with this feature included! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @csmarchbanks, I made the
start_http_serverfunction a bit easier to cancel gracefully.