Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-10865: Gather Node and PersistentVolume objects #393

Merged

Conversation

mpatlasov
Copy link
Contributor

The patch ensures that must-gather contains all node and pvs yaml-s. This is useful for debugging problems (see Problem Description in OCPBUGS-10865).

For example, in SNO setup I have one node and two pvs:

$ oc get nodes
NAME                 STATUS   ROLES                         AGE   VERSION
crc-8tnb7-master-0   Ready    control-plane,master,worker   13d   v1.25.7+eab9cc9

$ oc get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                                                 STORAGECLASS                   REASON   AGE
local-pv-53799107                          1Gi        RWO            Delete           Bound    default/claim1                                        local-sc                                5h3m
pvc-50372074-2c2b-4600-a4f1-c0bbc6917dd0   30Gi       RWX            Delete           Bound    openshift-image-registry/crc-image-registry-storage   crc-csi-hostpath-provisioner            12d

With this diff applied, must-gather contains:

$ ls -l cluster-scoped-resources/core/nodes/
total 16
-rwxr-xr-x. 1 maxim maxim 15780 Apr 10 15:15 crc-8tnb7-master-0.yaml

$ ls -l cluster-scoped-resources/core/persistentvolumes/
total 8
-rwxr-xr-x. 1 maxim maxim 3064 Apr 10 15:15 local-pv-53799107.yaml
-rwxr-xr-x. 1 maxim maxim 3008 Apr 10 15:15 pvc-50372074-2c2b-4600-a4f1-c0bbc6917dd0.yaml

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 11, 2023
@openshift-ci-robot
Copy link
Contributor

@mpatlasov: This pull request references Jira Issue OCPBUGS-10865, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The patch ensures that must-gather contains all node and pvs yaml-s. This is useful for debugging problems (see Problem Description in OCPBUGS-10865).

For example, in SNO setup I have one node and two pvs:

$ oc get nodes
NAME                 STATUS   ROLES                         AGE   VERSION
crc-8tnb7-master-0   Ready    control-plane,master,worker   13d   v1.25.7+eab9cc9

$ oc get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                                                 STORAGECLASS                   REASON   AGE
local-pv-53799107                          1Gi        RWO            Delete           Bound    default/claim1                                        local-sc                                5h3m
pvc-50372074-2c2b-4600-a4f1-c0bbc6917dd0   30Gi       RWX            Delete           Bound    openshift-image-registry/crc-image-registry-storage   crc-csi-hostpath-provisioner            12d

With this diff applied, must-gather contains:

$ ls -l cluster-scoped-resources/core/nodes/
total 16
-rwxr-xr-x. 1 maxim maxim 15780 Apr 10 15:15 crc-8tnb7-master-0.yaml

$ ls -l cluster-scoped-resources/core/persistentvolumes/
total 8
-rwxr-xr-x. 1 maxim maxim 3064 Apr 10 15:15 local-pv-53799107.yaml
-rwxr-xr-x. 1 maxim maxim 3008 Apr 10 15:15 pvc-50372074-2c2b-4600-a4f1-c0bbc6917dd0.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 11, 2023
@openshift-ci openshift-ci bot requested review from gnufied and jsafrane April 11, 2023 02:05
@mpatlasov
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 11, 2023
@openshift-ci-robot
Copy link
Contributor

@mpatlasov: This pull request references Jira Issue OCPBUGS-10865, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpatlasov
Copy link
Contributor Author

/assign @jsafrane

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit 79e4b14 into openshift:master Apr 11, 2023
@openshift-ci-robot
Copy link
Contributor

@mpatlasov: Jira Issue OCPBUGS-10865: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10865 has been moved to the MODIFIED state.

In response to this:

The patch ensures that must-gather contains all node and pvs yaml-s. This is useful for debugging problems (see Problem Description in OCPBUGS-10865).

For example, in SNO setup I have one node and two pvs:

$ oc get nodes
NAME                 STATUS   ROLES                         AGE   VERSION
crc-8tnb7-master-0   Ready    control-plane,master,worker   13d   v1.25.7+eab9cc9

$ oc get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                                                 STORAGECLASS                   REASON   AGE
local-pv-53799107                          1Gi        RWO            Delete           Bound    default/claim1                                        local-sc                                5h3m
pvc-50372074-2c2b-4600-a4f1-c0bbc6917dd0   30Gi       RWX            Delete           Bound    openshift-image-registry/crc-image-registry-storage   crc-csi-hostpath-provisioner            12d

With this diff applied, must-gather contains:

$ ls -l cluster-scoped-resources/core/nodes/
total 16
-rwxr-xr-x. 1 maxim maxim 15780 Apr 10 15:15 crc-8tnb7-master-0.yaml

$ ls -l cluster-scoped-resources/core/persistentvolumes/
total 8
-rwxr-xr-x. 1 maxim maxim 3064 Apr 10 15:15 local-pv-53799107.yaml
-rwxr-xr-x. 1 maxim maxim 3008 Apr 10 15:15 pvc-50372074-2c2b-4600-a4f1-c0bbc6917dd0.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants