Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-5.7] LOG-4456: Loki search does not allow special chars #136

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #130

/assign zhuje

…o form raw strings (``) instead of plain strings using quotes(""). This allows special characters to be escaped in Loki LogQL queries.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-14902 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

In response to this:

This is an automated cherry-pick of #130

/assign zhuje

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2023
@openshift-ci-robot
Copy link

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-14902, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected Jira Issue OCPBUGS-14902 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-14902 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

In response to this:

This is an automated cherry-pick of #130

/assign zhuje

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jgbernalp and kyoto August 21, 2023 18:30
@zhuje
Copy link
Contributor

zhuje commented Aug 21, 2023

related to : https://issues.redhat.com/browse/LOG-4456

@jgbernalp jgbernalp changed the title [release-5.7] OCPBUGS-14902: Loki search does not allow special chars [release-5.7] LOG-4456: Loki search does not allow special chars Aug 22, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 22, 2023

@openshift-cherrypick-robot: This pull request references LOG-4456 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #130

/assign zhuje

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jgbernalp
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhuje
Copy link
Contributor

zhuje commented Aug 22, 2023

/lgtm /approve

1 similar comment
@zhuje
Copy link
Contributor

zhuje commented Aug 24, 2023

/lgtm /approve

@zhuje
Copy link
Contributor

zhuje commented Aug 24, 2023

/lgtm

@zhuje
Copy link
Contributor

zhuje commented Aug 24, 2023

/approved

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@zhuje
Copy link
Contributor

zhuje commented Aug 31, 2023

/approved

@jgbernalp
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit bf742d5 into openshift:release-5.7 Aug 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants