LOG-4457: Loki search does not allow special chars

[zhuje]

Related Issue
https://issues.redhat.com/browse/OCPBUGS-14902

Summary
Fix the content filter by converting text input into a raw string (<text…>) instead of plain string (""). This allows special characters to be escaped within Loki LogQLs.

Resources
https://grafana.com/blog/2021/01/05/how-to-escape-special-characters-with-lokis-logql

Before
The text input ""manger-role"" causes a parsing error.

After
The text input is now wrapped in backtick (``) instead of quotes (""). The text input "manger-role" no longer causes a parsing error.

[openshift-ci-robot]

@zhuje: This pull request references Jira Issue OCPBUGS-14902, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Related Issue
https://issues.redhat.com/browse/OCPBUGS-14902

Summary
Fix the content filter by converting text input into a raw string (<text…>) instead of plain string (""). This allows special characters to be escaped within Loki LogQLs.

Resources
https://grafana.com/blog/2021/01/05/how-to-escape-special-characters-with-lokis-logql

Before
The text input ""manger-role"" causes a parsing error.

After
The text input is now wrapped in backtick (``) instead of quotes (""). The text input "manger-role" no longer causes a parsing error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kyoto]

I see there are a couple of test failures.

Also, with this approach I guess we won't be able to search for any string that contains a ` character. Although this is still a big improvement on the current behavior.

[zhuje]

/test test-e2e

[zhuje]

/retest

[jgbernalp]

@zhuje we need to fix the e2e tests as some of them are matching on the expected query and this changed including the ticks, in particular web/cypress/integration/logs-page.cy.ts

[openshift-ci]

@zhuje: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jgbernalp]

/lgtm

@zhuje we might need to update the JIRA ticket to add the specific logging version rather than the OCP version. Also this might need to be backported to 5.7

[zhuje]

/approved

[zhuje]

/jira refresh

[openshift-ci-robot]

@zhuje: This pull request references Jira Issue OCPBUGS-14902, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@zhuje: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Related Issue
https://issues.redhat.com/browse/OCPBUGS-14902

Summary
Fix the content filter by converting text input into a raw string (<text…>) instead of plain string (""). This allows special characters to be escaped within Loki LogQLs.

Resources
https://grafana.com/blog/2021/01/05/how-to-escape-special-characters-with-lokis-logql

Before
The text input ""manger-role"" causes a parsing error.

After
The text input is now wrapped in backtick (``) instead of quotes (""). The text input "manger-role" no longer causes a parsing error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zhuje]

/jira refresh

[openshift-ci-robot]

@zhuje: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@zhuje: This pull request references Jira Issue OCPBUGS-14902, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Related Issue
https://issues.redhat.com/browse/OCPBUGS-14902

Summary
Fix the content filter by converting text input into a raw string (<text…>) instead of plain string (""). This allows special characters to be escaped within Loki LogQLs.

Resources
https://grafana.com/blog/2021/01/05/how-to-escape-special-characters-with-lokis-logql

Before
The text input ""manger-role"" causes a parsing error.

After
The text input is now wrapped in backtick (``) instead of quotes (""). The text input "manger-role" no longer causes a parsing error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zhuje]

/jira refresh

[openshift-ci-robot]

@zhuje: This pull request references Jira Issue OCPBUGS-14902, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@zhuje: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Related Issue
https://issues.redhat.com/browse/OCPBUGS-14902

Summary
Fix the content filter by converting text input into a raw string (<text…>) instead of plain string (""). This allows special characters to be escaped within Loki LogQLs.

Resources
https://grafana.com/blog/2021/01/05/how-to-escape-special-characters-with-lokis-logql

Before
The text input ""manger-role"" causes a parsing error.

After
The text input is now wrapped in backtick (``) instead of quotes (""). The text input "manger-role" no longer causes a parsing error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@zhuje: This pull request references Jira Issue OCPBUGS-14902, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Related Issue
https://issues.redhat.com/browse/OCPBUGS-14902

Summary
Fix the content filter by converting text input into a raw string (<text…>) instead of plain string (""). This allows special characters to be escaped within Loki LogQLs.

Resources
https://grafana.com/blog/2021/01/05/how-to-escape-special-characters-with-lokis-logql

Before
The text input ""manger-role"" causes a parsing error.

After
The text input is now wrapped in backtick (``) instead of quotes (""). The text input "manger-role" no longer causes a parsing error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zhuje]

/jira refresh

[openshift-ci-robot]

@zhuje: This pull request references Jira Issue OCPBUGS-14902, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kyoto]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, zhuje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kyoto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@zhuje: Jira Issue OCPBUGS-14902: All pull requests linked via external trackers have merged:

• openshift/logging-view-plugin#130

Jira Issue OCPBUGS-14902 has been moved to the MODIFIED state.

In response to this:

Related Issue
https://issues.redhat.com/browse/OCPBUGS-14902

Summary
Fix the content filter by converting text input into a raw string (<text…>) instead of plain string (""). This allows special characters to be escaped within Loki LogQLs.

Resources
https://grafana.com/blog/2021/01/05/how-to-escape-special-characters-with-lokis-logql

Before
The text input ""manger-role"" causes a parsing error.

After
The text input is now wrapped in backtick (``) instead of quotes (""). The text input "manger-role" no longer causes a parsing error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zhuje]

/cherrypick release-5.7

[openshift-cherrypick-robot]

@zhuje: new pull request created: #136

In response to this:

/cherrypick release-5.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.