Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from upstream repository #283

Merged
merged 73 commits into from
Apr 16, 2024
Merged

Update from upstream repository #283

merged 73 commits into from
Apr 16, 2024

Conversation

periklis
Copy link

@periklis periklis commented Apr 10, 2024

cyriltovena and others added 30 commits April 4, 2024 17:24
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Co-authored-by: Anton Kolesnikov <anton.e.kolesnikov@gmail.com>
Co-authored-by: Sven Grossmann <svennergr@gmail.com>
Co-authored-by: Edward Welch <edward.welch@grafana.com>
…onal commits (#12439)

Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
…ests (#12470)

**What this PR does / why we need it**:

Use the same client-side sharding mechanism for bloom gateway filter requests that we use for client side sharding in the memcached client.

This uses DNS discovery to resolve a list of addresses uses as buckets for the jumphash algorithm to shard GroupedChunkRefs across bloom gateway servers.
The ring component is still part of the bloom gateway, but it is not used any more.


**Special notes for your reviewer**:

https://arxiv.org/pdf/1406.2294.pdf

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
…2474)

Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Co-authored-by: Robert Jacob <rojacob@redhat.com>
Remove ring in favour of a client side, DNS discovery of the bloom gateway servers combined with consistent hashing using the jumphash algorithm (#12470).

Instead of configuring the ring, the bloom gateway client needs to be configured with the `-bloom-gateway-client.addresses` flag, which takes a list of comma separated, DNS-discovery-style strings.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
…no longer so. (#12481)

Signed-off-by: Edward Welch <edward.welch@grafana.com>
#12181)

Co-authored-by: Robert Jacob <rojacob@redhat.com>
Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
…chema, and necessary directories are created (#12496)

Signed-off-by: Edward Welch <edward.welch@grafana.com>
Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: loki-gh-app[bot] <160051081+loki-gh-app[bot]@users.noreply.github.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@JoaoBraveCoding
Copy link

/retest-required

@periklis
Copy link
Author

/retest

@periklis
Copy link
Author

/retest

1 similar comment
@periklis
Copy link
Author

/retest

Copy link

openshift-ci bot commented Apr 16, 2024

@periklis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@periklis periklis merged commit 9206654 into openshift:main Apr 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet