Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-1769: Make machine phases public consts #1088

Merged
merged 2 commits into from
Dec 13, 2022
Merged

OCPCLOUD-1769: Make machine phases public consts #1088

merged 2 commits into from
Dec 13, 2022

Conversation

cjschaef
Copy link
Member

Rather than forcing machine providers to replicate the machine
phases, if needed, the phases should be made public consts instead.

Related: https://issues.redhat.com/browse/OCPCLOUD-1769

Requires: openshift/api#1358

@cjschaef
Copy link
Member Author

Requires API changes to merge so the go mod can be updated properly.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2022
@cjschaef
Copy link
Member Author

openshift/api#1358 has merged.
I will rebase and update go mod

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022
@cjschaef
Copy link
Member Author

cjschaef commented Dec 1, 2022

Rebased and tested locally with custom image.

@cjschaef
OCPCLOUD-1769: Make machine phases public consts
2452e28 
Rather than forcing machine providers to replicate the machine
phases, if needed, the phases should be made public consts instead.

Related: https://issues.redhat.com/browse/OCPCLOUD-1769
@cjschaef
Update openshift/api packages
db8e6f3 
Update the go mod and vendor packages to pull in the necessary
openshift/api changes for machine phases.
@cjschaef
Copy link
Member Author

cjschaef commented Dec 1, 2022

Rebase completed after local testing. Linting looks good, should be ready for review now.
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2022
@cjschaef
Copy link
Member Author

cjschaef commented Dec 2, 2022

Failures appear to be unrelated to this change, TF or secret genration, etc.
/retest

@cjschaef
Copy link
Member Author

cjschaef commented Dec 5, 2022

/retest

@cjschaef
Copy link
Member Author

cjschaef commented Dec 5, 2022

Looks like more conformance test failures, retrying
/retest

@cjschaef
Copy link
Member Author

cjschaef commented Dec 6, 2022

/retest

2 similar comments
@cjschaef
Copy link
Member Author

cjschaef commented Dec 7, 2022

/retest

@jeffnowicki
Copy link

/retest

@JoelSpeed
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ef0c106 and 2 for PR HEAD db8e6f3 in total

@JoelSpeed
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022 •
edited
Loading

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-operator db8e6f3 link false /test e2e-azure-operator
ci/prow/e2e-libvirt db8e6f3 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elmiko
Copy link
Contributor

elmiko commented Dec 12, 2022 •
edited
Loading

the aws test errors look like permission issues, which is concerning but probably unrelated to these changes.

Error from server (Forbidden): imagestreams.image.openshift.io "release" is forbidden: User "system:serviceaccount:ci-op-b5z6y3vk:e2e-aws-ovn-upgrade" cannot get resource "imagestreams" in API group "image.openshift.io" in the namespace "ci-op-b5z6y3vk"

the azure test failure looks interesting, i'm not convinced that it is related to this change though. likewise for libvirt.

@elmiko
Copy link
Contributor

elmiko commented Dec 12, 2022

i looked at the history for the e2e-azure-operator test and it seems to be failing in different ways for each run, i would chalk this up to flakes on the infrastructure.

@jeffnowicki
Copy link

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit fcbf953 into openshift:master Dec 13, 2022
@cjschaef cjschaef deleted the ocpcloud-1769 branch December 13, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beekhof beekhof Awaiting requested review from beekhof

@lobziik lobziik Awaiting requested review from lobziik

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjschaef @jeffnowicki @JoelSpeed @openshift-ci-robot @elmiko @openshift-merge-robot