CFE-684: Update GCPCloudCredentials with TagUser role

[bharath-b-rh]

PR is for updating CredentialRequest manifest of GCP with the TagUser role required for adding tags to GCP Compute Instances created by machine-api-provider-gcp.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[jianli-wei]

/label qe-approved

[openshift-ci-robot]

@bharath-b-rh: This pull request references CFE-684 which is a valid jira issue.

In response to this:

PR is for updating CredentialRequest manifest of GCP with the TagUser role required for adding tags to GCP Compute Instances created by machine-api-provider-gcp.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[bharath-b-rh]

/remove-lifecycle stale

[bharath-b-rh]

/cc @JoelSpeed

[JoelSpeed]

What's the motivation here? Why is this coming so late in the cycle? We are also trying to merge granular permissions (see #1178) for GCP into this release, the two will conflict.

Can you identify from this role, which permissions need to be added in the other PR to satisfy the requirements here?

[bharath-b-rh]

What's the motivation here?

These roles are required by machine-api-provider-gcp controller to add resource manager tags to Compute resources created by it.

Why is this coming so late in the cycle?

This is for the next release, it was in draft state, opened it for reviews for the next release.

We are also trying to merge granular permissions (see #1178) for GCP into this release, the two will conflict
Can you identify from this role, which permissions need to be added in the other PR to satisfy the requirements here?

Below additional permissions are required for managing tags

• compute.disks.createTagBinding
• compute.instances.createTagBinding
• resourcemanager.tagValues.get
• resourcemanager.tagValues.list

[JoelSpeed]

Changes look good, can we get some QE pre-merge validation on this feature before we merge though please. I can tag once QE are happy

[openshift-ci]

@bharath-b-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn	ad22ce7	link	false	/test e2e-vsphere-ovn
ci/prow/e2e-vsphere-operator	ad22ce7	link	false	/test e2e-vsphere-operator
ci/prow/e2e-metal-ipi-virtualmedia	ad22ce7	link	false	/test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-sdn	ad22ce7	link	false	/test e2e-metal-ipi-sdn
ci/prow/e2e-metal-ipi-upgrade	ad22ce7	link	false	/test e2e-metal-ipi-upgrade
ci/prow/e2e-vsphere-ovn-upgrade	ad22ce7	link	false	/test e2e-vsphere-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jianli-wei]

/label qe-approved

[jianli-wei]

@JoelSpeed QE pre-merge testing had passed (see comment), thanks!

[JoelSpeed]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment