Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-1725, OCPBUGS-25913: Add GCP custom roles #1178

Merged
merged 2 commits into from Jan 5, 2024
Merged

OCPCLOUD-1725, OCPBUGS-25913: Add GCP custom roles #1178

merged 2 commits into from Jan 5, 2024

Conversation

JoelSpeed
Copy link
Contributor

Reverts #1097 which reverted the addition of these roles originally.
This moves the the permissions from generic roles including many unusued permissions to a pruned and specific list of only the permissions we need.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 24, 2023 •
edited by openshift-ci bot

@JoelSpeed: This pull request references OCPCLOUD-1725 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Reverts #1097 which reverted the addition of these roles originally.
This moves the the permissions from generic roles including many unusued permissions to a pruned and specific list of only the permissions we need.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed JoelSpeed mentioned this pull request Nov 27, 2023
Merged
@JoelSpeed JoelSpeed force-pushed the revert-1097-revert-custom-role branch from 274aedb to 39bd33a Compare November 27, 2023 15:49
@JoelSpeed
Copy link
Contributor Author

Per email from @jstuever, putting this on hold until an issue is resolved in upgrades
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2023
damdo
damdo reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

damdo
damdo reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
elmiko
elmiko reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed JoelSpeed force-pushed the revert-1097-revert-custom-role branch from 246f74d to bd47d46 Compare December 18, 2023 14:00
@JoelSpeed
Copy link
Contributor Author

/test e2e-gcp-ovn

1 similar comment
@jstuever
Copy link

/test e2e-gcp-ovn

@JoelSpeed
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2024
damdo
damdo reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2024
@theobarberbany
Copy link

/lgtm

@JoelSpeed
Copy link
Contributor Author

/hold

Comment from Milind on https://issues.redhat.com/browse/OCPBUGS-25654 suggests there's a missing permission for deregistering instances from target groups, required for CPMS operation

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2024
@JoelSpeed JoelSpeed force-pushed the revert-1097-revert-custom-role branch from bd47d46 to c638e72 Compare January 4, 2024 11:35
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-serial c638e72 link false /test e2e-vsphere-ovn-serial
ci/prow/e2e-vsphere-ovn-upgrade c638e72 link false /test e2e-vsphere-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
damdo
damdo reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8d8b7e5 into master Jan 5, 2024
24 of 26 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-api-operator-container-v4.16.0-202401051532.p0.g8d8b7e5.assembly.stream for distgit ose-machine-api-operator.
All builds following this will include this PR.

@JoelSpeed JoelSpeed changed the title OCPCLOUD-1725: Add GCP custom roles OCPCLOUD-1725, OCPBUGS-25913: Add GCP custom roles Jan 8, 2024
@openshift-ci-robot
Copy link
Contributor

@JoelSpeed: Jira Issue OCPBUGS-25913: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25913 has been moved to the MODIFIED state.

In response to this:

Reverts #1097 which reverted the addition of these roles originally.
This moves the the permissions from generic roles including many unusued permissions to a pruned and specific list of only the permissions we need.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@JoelSpeed: new pull request created: #1196

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@damdo damdo damdo left review comments

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@damdo damdo

@theobarberbany theobarberbany

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@JoelSpeed @openshift-ci-robot @jstuever @theobarberbany @openshift-bot @openshift-cherrypick-robot @elmiko @damdo