Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-1386: reconcile additional tags assigned to machine #1182

Closed
wants to merge 2 commits into from

Conversation

rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Dec 1, 2023

This PR intends to address RFE https://issues.redhat.com/browse/RFE-1799. Additional tags are provided by the declaring a slice of tags referenced by their URN ID. This is consistent with how CAPV ingests additional tags for a VM.

Depends on openshift/api#1697

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 1, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2023

@rvanderp3: This pull request references SPLAT-1281 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2023
Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-ovn

@rvanderp3 rvanderp3 closed this Dec 4, 2023
@rvanderp3 rvanderp3 reopened this Dec 4, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2023

@rvanderp3: This pull request references SPLAT-1281 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-ovn

@rvanderp3 rvanderp3 force-pushed the SPLAT-1281 branch 5 times, most recently from b11bf8b to 0cdddd4 Compare December 6, 2023 15:11
@rvanderp3
Copy link
Contributor Author

/test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 6, 2023

@rvanderp3: This pull request references SPLAT-1281 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

In response to this:

This PR intends to address RFE https://issues.redhat.com/browse/RFE-2176. Additional tags are provided by the declaring a slice of tags referenced by their URN ID. This is consistent with how CAPV ingests additional tags for a VM.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 6, 2023

@rvanderp3: This pull request references SPLAT-1281 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

In response to this:

This PR intends to address RFE https://issues.redhat.com/browse/RFE-2176. Additional tags are provided by the declaring a slice of tags referenced by their URN ID. This is consistent with how CAPV ingests additional tags for a VM.

Depends on openshift/api#1697

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3 rvanderp3 force-pushed the SPLAT-1281 branch 2 times, most recently from 7185719 to e6db30d Compare December 6, 2023 17:47
@rvanderp3 rvanderp3 marked this pull request as ready for review December 6, 2023 17:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2023
@rvanderp3 rvanderp3 changed the title SPLAT-1281: WIP: reconcile additional tags assigned to machine SPLAT-1281: reconcile additional tags assigned to machine Dec 6, 2023
@openshift-ci openshift-ci bot requested review from damdo and elmiko December 6, 2023 17:49
@rvanderp3
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn-techpreview

Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

@rvanderp3: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message. could not check if the user rvanderp3 is trusted for pull request openshift/machine-api-operator#1182: error checking rvanderp3 for trust: error in IsMember(openshift): Get "http://ghproxy/orgs/openshift/members/rvanderp3": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue.

@rvanderp3
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn-techpreview

Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

@rvanderp3: trigger 2 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn
  • periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8d09e690-9468-11ee-9515-f4557dcb95ea-0

@rvanderp3
Copy link
Contributor Author

/hold

placing hold until API merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023
@rvanderp3
Copy link
Contributor Author

payload jobs are passing

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2023

@rvanderp3: This pull request references SPLAT-1281 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

This PR intends to address RFE https://issues.redhat.com/browse/RFE-1799. Additional tags are provided by the declaring a slice of tags referenced by their URN ID. This is consistent with how CAPV ingests additional tags for a VM.

Depends on openshift/api#1697

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn-techpreview

Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

@rvanderp3: trigger 2 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn
  • periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f4a36210-b004-11ee-98bb-46c2c413339c-0

Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-serial 2137696 link false /test e2e-vsphere-ovn-serial
ci/prow/e2e-vsphere-ovn-upgrade 2137696 link false /test e2e-vsphere-ovn-upgrade
ci/prow/e2e-vsphere-ovn 2137696 link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvanderp3 rvanderp3 changed the title SPLAT-1281: reconcile additional tags assigned to machine SPLAT-1385: reconcile additional tags assigned to machine Jan 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 12, 2024

@rvanderp3: This pull request references SPLAT-1385 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This PR intends to address RFE https://issues.redhat.com/browse/RFE-1799. Additional tags are provided by the declaring a slice of tags referenced by their URN ID. This is consistent with how CAPV ingests additional tags for a VM.

Depends on openshift/api#1697

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rvanderp3 rvanderp3 changed the title SPLAT-1385: reconcile additional tags assigned to machine SPLAT-1386: reconcile additional tags assigned to machine Jan 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 12, 2024

@rvanderp3: This pull request references SPLAT-1386 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This PR intends to address RFE https://issues.redhat.com/browse/RFE-1799. Additional tags are provided by the declaring a slice of tags referenced by their URN ID. This is consistent with how CAPV ingests additional tags for a VM.

Depends on openshift/api#1697

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rvanderp3 rvanderp3 closed this Jan 15, 2024
@rvanderp3 rvanderp3 deleted the SPLAT-1281 branch January 15, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants