SPLAT-1385: introduce TagIDs field to vSphere providerSpec #1697
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rvanderp3: This pull request references SPLAT-1281 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hello @rvanderp3! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/S
|
@rvanderp3: This pull request references SPLAT-1281 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @JoelSpeed |
|
/lgtm |
|
/payload 4.15 nightly informing |
|
@rvanderp3: trigger 62 job(s) of type informing for the nightly release of OCP 4.15
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e8685230-9466-11ee-9db6-e3855f6b6c8d-0 |
|
/payload-abort |
|
@rvanderp3: aborted active payload jobs for pull request #1697 |
| // must use URN-notation instead of display names. | ||
| // For example: urn:vmomi:InventoryServiceTag:5736bf56-49f5-4667-b38c-b97e09dc9578:GLOBAL | ||
| // +optional | ||
| TagIDs []string `json:"tagIDs,omitempty"` |
There was a problem hiding this comment.
How is this handled in the upstream CAPV?
There was a problem hiding this comment.
This mirrors the CAPV API.
|
@rvanderp3: This pull request references SPLAT-1281 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -51,6 +51,11 @@ type VSphereMachineProviderSpec struct { | |||
| // This parameter will be ignored if 'LinkedClone' CloneMode is set. | |||
| // +optional | |||
| DiskGiB int32 `json:"diskGiB,omitempty"` | |||
| // TagIDs is an optional set of tags to add to an instance. Specified tagIDs | |||
There was a problem hiding this comment.
| // TagIDs is an optional set of tags to add to an instance. Specified tagIDs | |
| // tagIDs is an optional set of tags to add to an instance. Specified tagIDs |
| // must use URN-notation instead of display names. | ||
| // For example: urn:vmomi:InventoryServiceTag:5736bf56-49f5-4667-b38c-b97e09dc9578:GLOBAL | ||
| // +optional | ||
| TagIDs []string `json:"tagIDs,omitempty"` |
There was a problem hiding this comment.
Is there a limit to the number of tags that can be applied?
There was a problem hiding this comment.
There isn't a hard limit upstream but excessive tags could cause latency in machine reconciliation. We could impose an arbitrary maximum.
There was a problem hiding this comment.
There isn't a hard limit, but there is performance hit if we allow too many tags to be reconciled and attached. For now, setting a 10 tag limit.
| @@ -51,6 +51,11 @@ type VSphereMachineProviderSpec struct { | |||
| // This parameter will be ignored if 'LinkedClone' CloneMode is set. | |||
| // +optional | |||
| DiskGiB int32 `json:"diskGiB,omitempty"` | |||
| // TagIDs is an optional set of tags to add to an instance. Specified tagIDs | |||
| // must use URN-notation instead of display names. | |||
| // For example: urn:vmomi:InventoryServiceTag:5736bf56-49f5-4667-b38c-b97e09dc9578:GLOBAL | |||
There was a problem hiding this comment.
Where will this format be validated?
There was a problem hiding this comment.
At present, we are relying on the vCenter API to perform validation during reconciliation but I'll add regex to enforce this in the CRD.
There was a problem hiding this comment.
Introduced validation in the machine webhook
rvanderp3
changed the title
|
@rvanderp3: This pull request references SPLAT-1385 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, rvanderp3, vr4manta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@rvanderp3: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.16.0-202401161431.p0.g0793e91.assembly.stream for distgit ose-cluster-config-api. |
This PR intends to address RFE https://issues.redhat.com/browse/RFE-1799. Additional tags are provided by the declaring a slice of tags referenced by their URN ID. This is consistent with how CAPV ingests additional tags for a VM.