Fixup cluster operator #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold pending merge of openshift/cluster-version-operator#115 |
openshift-ci-robot
added
do-not-merge/hold
derekwaynecarr
force-pushed
the
fixup-cluster-operator
branch
from
4ab5b9a
to
4e974d8
Compare
derekwaynecarr
force-pushed
the
fixup-cluster-operator
branch
from
4e974d8
to
a358a8f
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@enxebre it's not obvious to me what is happening here, do you see an obvious change? |
|
@derekwaynecarr thanks a lot! pr looks good. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-aws-operator |
ingvagabund
pushed a commit
to ingvagabund/machine-api-operator
that referenced
this pull request
Jul 11, 2019
fix source paths when invoking vet and fmt scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the following:
ClusterOperatorresource to namemachine-apiopenshift-must-gatherwhen gathering diagnostic info can collect information from theopenshift-cluster-apinamespace.See https://github.com/openshift/must-gather