Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unused labels #255

Merged
merged 1 commit into from Apr 2, 2019
Merged

Drop unused labels #255

merged 1 commit into from Apr 2, 2019

Conversation

vikaschoudhary16
Copy link
Contributor

@vikaschoudhary16 vikaschoudhary16 commented Mar 25, 2019 •
edited

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2019
cynepco3hahue
cynepco3hahue reviewed Mar 25, 2019
View reviewed changes
pkg/controller/machinehealthcheck/machinehealthcheck_controller.go
"sigs.k8s.io/cluster-api-machine-type",
}
nodeMasterLabels := []string{
masterLabels := []string{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to check machine labels at all?
IMHO the only proper way is to check node labels that machine reference to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. @vikaschoudhary16 as part of this effort can we drop labels here https://github.com/openshift/installer/tree/master/pkg/asset/machines/aws
And update https://github.com/openshift/origin/pull/22090/files#r267287918 to fetch from node accordingly cc @ingvagabund @derekwaynecarr

@vikaschoudhary16 vikaschoudhary16 mentioned this pull request Mar 27, 2019
Merged
@vikaschoudhary16
Copy link
Contributor Author

/retest

@enxebre
Copy link
Member

enxebre commented Apr 2, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2019
@ingvagabund
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@openshift-merge-robot openshift-merge-robot merged commit a037e16 into openshift:master Apr 2, 2019
enxebre pushed a commit to enxebre/machine-api-operator that referenced this pull request Apr 2, 2019
@openshift-merge-robot @enxebre
Merge pull request openshift#255 from vikaschoudhary16/drop-unused-la…
06d88c0 
…bels

Drop unused labels
@vikaschoudhary16 vikaschoudhary16 deleted the drop-unused-labels branch April 4, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@cynepco3hahue cynepco3hahue cynepco3hahue left review comments

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vikaschoudhary16 @enxebre @openshift-ci-robot @ingvagabund @cynepco3hahue @openshift-merge-robot