Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate api #440

Merged
merged 3 commits into from Nov 28, 2019
Merged

Migrate api #440

merged 3 commits into from Nov 28, 2019

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Nov 27, 2019

Although we continue to strongly aim for an eventual convergence with upstream there's no reason for working in a cluster-api fork workflow any longer, therefore we are deprecating openshift/cluster-api to relax the dependency hassle existing today between multiple repositories: kube libraries, mao, openshift/cluster-api, actuators...
Once upstream gets matured we'll consider re-organising the code structure again.
This is a transitional step before moving the machine.openshift.io API into openshift/api.
In a follow up machine/machineSet controllers will be moved into this repo and openshift/cluster-api will be archived.

…9258f5c3117cb2aba6a560babe0d59f8

There's no reason for working in a cluster-api fork workflow any longer, therefore we are deprecating openshift/cluster-api to relax the dependency hassle exising today between multiple repositories: kube libraries, mao, openshift/cluster-api, actuators...
Once upstream gets matured we'll consider re-organising the code structure again.
This is a transitional step before moving the machine.openshift.io API into openshift/api.
In a follow up machine/machineSet controllers will be moved into this repo and openshift/cluster-api will be archived.
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 27, 2019
@enxebre enxebre mentioned this pull request Nov 27, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 27, 2019

@enxebre: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-operator 7464920 link /test e2e-gcp-operator
ci/prow/e2e-azure 7464920 link /test e2e-azure
ci/prow/e2e-azure-operator 7464920 link /test e2e-azure-operator
ci/prow/e2e-aws-scaleup-rhel7 7464920 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-gcp 7464920 link /test e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member Author

enxebre commented Nov 27, 2019

/test e2e-aws

Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2019
@openshift-merge-robot openshift-merge-robot merged commit 54fa05b into openshift:master Nov 28, 2019
@enxebre enxebre mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants