New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate controllers #441
Migrate controllers #441
Conversation
/test e2e-aws-operator |
08299f7
to
d3525ad
Compare
/test e2e-aws |
d3525ad
to
87b22f6
Compare
/hold cancel |
…-api at 9a3a7bbe9258f5c3117cb2aba6a560babe0d59f8 Although we continue to strongly aim for an eventual convergence with upstream there's no reason for working in a cluster-api fork workflow any longer, therefore we are deprecating openshift/cluster-api to relax the dependency hassle existing today between multiple repositories: kube libraries, mao, openshift/cluster-api, actuators... Once upstream gets matured we'll consider re-organising the code structure again.
87b22f6
to
1b65785
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bison The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-aws |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-aws |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@enxebre: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The machineset controller development was moved into this repo openshift#441 and the vsphere actuator lives in this repo, therefore the binaries live in the mao image unlike other providers with their own image e.g aws
The machineset controller development was moved into this repo openshift#441 and the vsphere actuator lives in this repo, therefore the binaries live in the mao image unlike other providers with their own image e.g aws
Although we continue to strongly aim for an eventual convergence with upstream there's no reason for working in a cluster-api fork workflow any longer, therefore we are deprecating openshift/cluster-api to relax the dependency hassle existing today between multiple repositories: kube libraries, mao, openshift/cluster-api, actuators...
Once upstream gets matured we'll consider re-organising the code structure again.
Providers:
openshift/cluster-api-provider-aws#276
openshift/cluster-api-provider-azure#94
openshift/cluster-api-provider-gcp#67
Needs #440
/hold